test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH 0/2] add and update support for Mellanox nics
@ 2018-01-07 16:01 Ali Alnubani
  2018-01-07 16:01 ` [dts] [PATCH 1/2] settings: update mellanox's nics and their identifiers Ali Alnubani
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Ali Alnubani @ 2018-01-07 16:01 UTC (permalink / raw)
  To: dts; +Cc: rasland

This patch set is to update the identifiers of currently supported
Mellanox nics, and to support more ones.

Ali Alnubani (2):
  settings: update mellanox's nics and their identifiers
  project_dpdk: move driver specific configurations to a separate method

 framework/project_dpdk.py | 16 ++++++++++++----
 framework/settings.py     | 14 ++++++++++----
 2 files changed, 22 insertions(+), 8 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH 1/2] settings: update mellanox's nics and their identifiers
  2018-01-07 16:01 [dts] [PATCH 0/2] add and update support for Mellanox nics Ali Alnubani
@ 2018-01-07 16:01 ` Ali Alnubani
  2018-01-07 16:01 ` [dts] [PATCH 2/2] project_dpdk: move driver specific configurations to a separate method Ali Alnubani
  2018-01-09 13:14 ` [dts] [PATCH 0/2] add and update support for Mellanox nics Liu, Yong
  2 siblings, 0 replies; 4+ messages in thread
From: Ali Alnubani @ 2018-01-07 16:01 UTC (permalink / raw)
  To: dts; +Cc: rasland

    - Be more specific in nic names.
    - Update ConnectX-3's device identifier.
    - Add support for ConnectX-4 LX and ConnectX-5.

Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
 framework/settings.py | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/framework/settings.py b/framework/settings.py
index e5b7746..df3ac88 100644
--- a/framework/settings.py
+++ b/framework/settings.py
@@ -87,8 +87,11 @@ NICS = {
     'fortpark_TLV_vf': '8086:37cd',
     'fvl10g_vf': '8086:154c',
     'atwood': '8086:15d5',
-    'ConnectX3': '15b3:1003',
-    'ConnectX4': '15b3:1013',
+    'ConnectX3_MT4103': '15b3:1007',
+    'ConnectX4_MT4115': '15b3:1013',
+    'ConnectX4_LX_MT4117': '15b3:1015',
+    'ConnectX5_MT4119': '15b3:1017',
+    'ConnectX5_MT4121': '15b3:1019',
     'boulderrapid': '8086:15d0',
     'fortville_25g': '8086:158b',
     'cavium_a034': '177d:a034',
@@ -134,8 +137,11 @@ DRIVERS = {
     'fortpark_TLV_vf': 'i40evf',
     'fvl10g_vf': 'i40evf',
     'atwood': 'fm10k',
-    'ConnectX3': 'mlx4_core',
-    'ConnectX4': 'mlx5_core',
+    'ConnectX3_MT4103': 'mlx4_core',
+    'ConnectX4_MT4115': 'mlx5_core',
+    'ConnectX4_LX_MT4117': 'mlx5_core',
+    'ConnectX5_MT4119': 'mlx5_core',
+    'ConnectX5_MT4121': 'mlx5_core',
     'boulderrapid': 'fm10k',
     'fortville_25g': 'i40e',
     'cavium_a034': 'thunder-nicvf',
-- 
2.7.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH 2/2] project_dpdk: move driver specific configurations to a separate method
  2018-01-07 16:01 [dts] [PATCH 0/2] add and update support for Mellanox nics Ali Alnubani
  2018-01-07 16:01 ` [dts] [PATCH 1/2] settings: update mellanox's nics and their identifiers Ali Alnubani
@ 2018-01-07 16:01 ` Ali Alnubani
  2018-01-09 13:14 ` [dts] [PATCH 0/2] add and update support for Mellanox nics Liu, Yong
  2 siblings, 0 replies; 4+ messages in thread
From: Ali Alnubani @ 2018-01-07 16:01 UTC (permalink / raw)
  To: dts; +Cc: rasland

Enable both MLX4 and MLX5 PMDs before compiling dpdk, and do that
in a separate method.

Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
 framework/project_dpdk.py | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
index 6bc47f2..1f673c9 100644
--- a/framework/project_dpdk.py
+++ b/framework/project_dpdk.py
@@ -71,11 +71,9 @@ class DPDKdut(Dut):
 
         self.set_rxtx_mode()
 
-        # Enable MLNX driver before installing dpdk
         drivername = load_global_setting(HOST_DRIVER_SETTING)
-        if drivername == DRIVERS['ConnectX4']:
-            self.send_expect("sed -i -e 's/CONFIG_RTE_LIBRTE_MLX5_PMD=n/"
-                             + "CONFIG_RTE_LIBRTE_MLX5_PMD=y/' config/common_base", "# ", 30)
+
+        self.set_driver_specific_configurations(drivername)
 
         if not self.skip_setup:
             self.build_install_dpdk(target)
@@ -431,6 +429,16 @@ class DPDKdut(Dut):
         # No blacklist option in FreeBSD
         return blacklist
 
+    def set_driver_specific_configurations(self, drivername):
+        """
+        Set configurations required for specific drivers before compilation.
+        """
+        # Enable Mellanox drivers
+        if drivername == "mlx5_core" or drivername == "mlx4_core":
+            self.send_expect("sed -i -e 's/CONFIG_RTE_LIBRTE_MLX5_PMD=n/"
+                             + "CONFIG_RTE_LIBRTE_MLX5_PMD=y/' config/common_base", "# ", 30)
+            self.send_expect("sed -i -e 's/CONFIG_RTE_LIBRTE_MLX4_PMD=n/"
+                             + "CONFIG_RTE_LIBRTE_MLX5_PMD=y/' config/common_base", "# ", 30)
 
 class DPDKtester(Tester):
 
-- 
2.7.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH 0/2] add and update support for Mellanox nics
  2018-01-07 16:01 [dts] [PATCH 0/2] add and update support for Mellanox nics Ali Alnubani
  2018-01-07 16:01 ` [dts] [PATCH 1/2] settings: update mellanox's nics and their identifiers Ali Alnubani
  2018-01-07 16:01 ` [dts] [PATCH 2/2] project_dpdk: move driver specific configurations to a separate method Ali Alnubani
@ 2018-01-09 13:14 ` Liu, Yong
  2 siblings, 0 replies; 4+ messages in thread
From: Liu, Yong @ 2018-01-09 13:14 UTC (permalink / raw)
  To: Ali Alnubani, dts; +Cc: rasland

Thanks Ali, applied.

On 01/08/2018 12:01 AM, Ali Alnubani wrote:
> This patch set is to update the identifiers of currently supported
> Mellanox nics, and to support more ones.
>
> Ali Alnubani (2):

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-01-09  5:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-07 16:01 [dts] [PATCH 0/2] add and update support for Mellanox nics Ali Alnubani
2018-01-07 16:01 ` [dts] [PATCH 1/2] settings: update mellanox's nics and their identifiers Ali Alnubani
2018-01-07 16:01 ` [dts] [PATCH 2/2] project_dpdk: move driver specific configurations to a separate method Ali Alnubani
2018-01-09 13:14 ` [dts] [PATCH 0/2] add and update support for Mellanox nics Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).