test suite reviews and discussions
 help / color / mirror / Atom feed
From: yufengx.mo@intel.com
To: dts@dpdk.org
Cc: yufengmx <yufengx.mo@intel.com>
Subject: [dts] [PATCH V1]tests/userspace_ethtool: fix test_ethtool_vlan case failed
Date: Tue, 30 Jan 2018 14:43:34 +0800	[thread overview]
Message-ID: <1517294614-22458-2-git-send-email-yufengx.mo@intel.com> (raw)
In-Reply-To: <1517294614-22458-1-git-send-email-yufengx.mo@intel.com>

From: yufengmx <yufengx.mo@intel.com>


vlan filter failed issue is caused by pmd option offload change.
'cfg_port.rxmode.hw_vlan_filter' is abandoned after the commit
008ee817dfbe133e03717a37743f115d21e1a479. change sed command content
before
cfg_port.rxmode.hw_vlan_filter=1
current
cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN_FILTER

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index a901a47..84b1f1e 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -411,7 +411,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         """
         main_file = "examples/ethtool/ethtool-app/main.c"
         # enable vlan filter
-        self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.hw_vlan_filter=1;' %s" % main_file, "# ")
+        self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN_FILTER;' %s" % main_file, "# ")
 
         # build sample app
         self.build_ethtool()
-- 
1.9.3

  reply	other threads:[~2018-01-30  6:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30  6:43 [dts] [PATCH V1]tests/userspace_ethtool: fix test_ethtool_vlan case failed issue yufengx.mo
2018-01-30  6:43 ` yufengx.mo [this message]
2018-01-30 14:46   ` [dts] [PATCH V1]tests/userspace_ethtool: fix test_ethtool_vlan case failed Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517294614-22458-2-git-send-email-yufengx.mo@intel.com \
    --to=yufengx.mo@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).