test suite reviews and discussions
 help / color / mirror / Atom feed
From: "xu,gang" <gangx.xu@intel.com>
To: dts@dpdk.org
Cc: "xu,gang" <gangx.xu@intel.com>
Subject: [dts] [PATCH V1] fix csum set issue
Date: Fri,  9 Feb 2018 16:37:12 +0800	[thread overview]
Message-ID: <1518165432-50984-1-git-send-email-gangx.xu@intel.com> (raw)

When we run command "csum set ip/udp/tcp/sctp hw $port_id", need stop port first.
And we run command "csum set ip/udp/tcp/sctp sw $port_id", need too


Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_nvgre.py | 2 ++
 tests/TestSuite_vxlan.py | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/tests/TestSuite_nvgre.py b/tests/TestSuite_nvgre.py
index d64c3cb..99b8490 100644
--- a/tests/TestSuite_nvgre.py
+++ b/tests/TestSuite_nvgre.py
@@ -551,12 +551,14 @@ class TestNvgre(TestCase):
         # enable tx checksum offload
         self.dut.send_expect("set verbose 1", "testpmd>", 10)
         self.dut.send_expect("set fwd csum", "testpmd>", 10)
+        self.dut.send_expect("port stop all", "testpmd>")
         self.dut.send_expect("csum set ip hw %d" % (self.dut_tx_port), "testpmd>", 10)
         self.dut.send_expect("csum set udp hw %d" % (self.dut_tx_port), "testpmd>", 10)
         self.dut.send_expect("csum set tcp hw %d" % (self.dut_tx_port), "testpmd>", 10)
         self.dut.send_expect("csum set sctp hw %d" % (self.dut_tx_port), "testpmd>", 10)
         self.dut.send_expect("csum set outer-ip hw %d" % (self.dut_tx_port), "testpmd>", 10)
         self.dut.send_expect("csum parse_tunnel on %d" % (self.dut_tx_port), "testpmd>", 10)
+        self.dut.send_expect("port start all", "testpmd>")
 
         # log the nvgre format
         arg_str = ""
diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
index 2e971d1..17a34d4 100644
--- a/tests/TestSuite_vxlan.py
+++ b/tests/TestSuite_vxlan.py
@@ -1142,14 +1142,18 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
                              "testpmd>", 10)
 
     def csum_set_type(self, proto, port):
+        self.dut.send_expect("port stop all", "testpmd>")
         out = self.dut.send_expect("csum set %s hw %d" % (proto, port),
                                    "testpmd>", 10)
+        self.dut.send_expect("port start all", "testpmd>")
         self.verify("Bad arguments" not in out, "Failed to set vxlan csum")
         self.verify("error" not in out, "Failed to set vxlan csum")
 
     def csum_set_sw(self, proto, port):
+        self.dut.send_expect("port stop all", "testpmd>")
         out = self.dut.send_expect("csum set %s sw %d" % (proto, port),
                                    "testpmd>", 10)
+        self.dut.send_expect("port start all", "testpmd>")
         self.verify("Bad arguments" not in out, "Failed to set vxlan csum")
         self.verify("error" not in out, "Failed to set vxlan csum")
 
-- 
1.9.3

             reply	other threads:[~2018-02-09  8:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09  8:37 xu,gang [this message]
2018-02-11 10:11 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518165432-50984-1-git-send-email-gangx.xu@intel.com \
    --to=gangx.xu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).