From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id A73231B341 for ; Mon, 12 Feb 2018 10:58:30 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 292221650; Mon, 12 Feb 2018 01:58:30 -0800 (PST) Received: from lenovo-a010984.shanghai.arm.com (lenovo-a010984.shanghai.arm.com [10.169.40.44]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B06363F41F; Mon, 12 Feb 2018 01:58:29 -0800 (PST) From: Herbert Guan To: dts@dpdk.org Cc: Herbert Guan Date: Mon, 12 Feb 2018 17:57:42 +0800 Message-Id: <1518429462-30299-10-git-send-email-herbert.guan@arm.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1518429462-30299-1-git-send-email-herbert.guan@arm.com> References: <1518157565-17167-1-git-send-email-herbert.guan@arm.com> <1518429462-30299-1-git-send-email-herbert.guan@arm.com> Subject: [dts] [PATCH v2 9/9] tests/vf_macfilter: use virt_common for VM creation X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 09:58:31 -0000 Use 'VM' form virt_common instead of 'QEMUKvm' from qemu_kvm for VM creation. This will allow VM type selection (kvm/libvirt etc.) for each VM defined in test suite's config file. Signed-off-by: Herbert Guan --- conf/vf_macfilter.cfg | 97 ++++++----------------------------------- tests/TestSuite_vf_macfilter.py | 4 +- 2 files changed, 15 insertions(+), 86 deletions(-) diff --git a/conf/vf_macfilter.cfg b/conf/vf_macfilter.cfg index ddf3168..b4a5eb4 100644 --- a/conf/vf_macfilter.cfg +++ b/conf/vf_macfilter.cfg @@ -1,100 +1,29 @@ -# QEMU options -# name -# name: vm0 -# -# enable_kvm -# enable: [yes | no] -# -# cpu -# model: [host | core2duo | ...] -# usage: -# choose model value from the command -# qemu-system-x86_64 -cpu help -# number: '4' #number of vcpus -# cpupin: '3 4 5 6' # host cpu list -# -# mem -# size: 1024 -# -# disk -# file: /path/to/image/test.img -# -# net -# type: [nic | user | tap | bridge | ...] -# nic -# opt_vlan: 0 -# note: Default is 0. -# opt_macaddr: 00:00:00:00:01:01 -# note: if creating a nic, it`s better to specify a MAC, -# else it will get a random number. -# opt_model:["e1000" | "virtio" | "i82551" | ...] -# note: Default is e1000. -# opt_name: 'nic1' -# opt_addr: '' -# note: PCI cards only. -# opt_vectors: -# note: This option currently only affects virtio cards. -# user -# opt_vlan: 0 -# note: default is 0. -# opt_hostfwd: [tcp|udp]:[hostaddr]:hostport-[guestaddr]:guestport -# note: If not specified, it will be setted automatically. -# tap -# opt_vlan: 0 -# note: default is 0. -# opt_br: br0 -# note: if choosing tap, need to specify bridge name, -# else it will be br0. -# opt_script: QEMU_IFUP_PATH -# note: if not specified, default is self.QEMU_IFUP_PATH. -# opt_downscript: QEMU_IFDOWN_PATH -# note: if not specified, default is self.QEMU_IFDOWN_PATH. -# -# device -# driver: [pci-assign | virtio-net-pci | ...] -# pci-assign -# prop_host: 08:00.0 -# prop_addr: 00:00:00:00:01:02 -# virtio-net-pci -# prop_netdev: mynet1 -# prop_id: net1 -# prop_mac: 00:00:00:00:01:03 -# prop_bus: pci.0 -# prop_addr: 0x3 -# -# monitor -# port: 6061 -# note: if adding monitor to vm, need to specicy -# this port, else it will get a free port -# on the host machine. -# -# serial_port -# enable: [yes | no] -# -# vnc -# displayNum: 1 -# note: you can choose a number not used on the host. -# -# daemon -# enable: 'yes' -# note: -# By default VM will start with the daemonize status. -# Not support starting it on the stdin now. - -# vm configuration for pmd sriov case +# Configuration sample: sriov_kvm.cfg [vm0] +# Default virt_type is KVM +#virt_type = +# virt_type=LIBVIRT; +# os option is applicable for libvirt only +#os = +# loader=/usr/share/AAVMF/AAVMF_CODE.fd,nvram=/var/lib/libvirt/qemu/nvram/DTSVM_VARS.fd; cpu = model=host,number=4,cpupin=5 6 7 8; disk = file=/home/img/sriov-fc20-1.img; +# Example for libvirt: +# file=/var/lib/libvirt/images/DTSVM.qcow2,opt_format=qcow2,opt_bus=scsi,opt_dev=sda,opt_controller=virtio-scsi; login = user=root,password=tester; +# net option is not necessary for libvirt, comment out below 2 lines if using libvirt net = type=nic,opt_vlan=0; type=user,opt_vlan=0; +# monitor option is not supported by libvirt yet, comment out below 2 lines if using libvirt monitor = port=; +# vnc option is not supported by libvirt yet, comment out below 2 lines if using libvirt vnc = displayNum=1; +# daemon option is not supported by libvirt yet, comment out below 2 lines if using libvirt daemon = enable=yes; diff --git a/tests/TestSuite_vf_macfilter.py b/tests/TestSuite_vf_macfilter.py index 23105a4..f0de169 100644 --- a/tests/TestSuite_vf_macfilter.py +++ b/tests/TestSuite_vf_macfilter.py @@ -3,7 +3,7 @@ import re import time -from qemu_kvm import QEMUKvm +from virt_common import VM from test_case import TestCase from pmd_output import PmdOutput @@ -71,7 +71,7 @@ class TestVfMacFilter(TestCase): self.host_testpmd.start_testpmd("1S/2C/2T", eal_param=eal_param) # set up VM0 ENV - self.vm0 = QEMUKvm(self.dut, 'vm0', 'vf_macfilter') + self.vm0 = VM(self.dut, 'vm0', 'vf_macfilter') self.vm0.set_vm_device(driver=self.vf_assign_method, **vf0_prop) self.vm0.set_vm_device(driver=self.vf_assign_method, **vf1_prop) self.vm_dut_0 = self.vm0.start() -- 1.8.3.1