test suite reviews and discussions
 help / color / mirror / Atom feed
From: Herbert Guan <herbert.guan@arm.com>
To: dts@dpdk.org
Cc: Herbert Guan <herbert.guan@arm.com>
Subject: [dts] [PATCH v2 4/9] tests/vf_vlan: use virt_common for VM creation
Date: Mon, 12 Feb 2018 17:57:37 +0800	[thread overview]
Message-ID: <1518429462-30299-5-git-send-email-herbert.guan@arm.com> (raw)
In-Reply-To: <1518429462-30299-1-git-send-email-herbert.guan@arm.com>

Use 'VM' form virt_common instead of 'QEMUKvm' from qemu_kvm for VM
creation.  This will allow VM type selection (kvm/libvirt etc.) for
each VM defined in test suite's config file.


Signed-off-by: Herbert Guan <herbert.guan@arm.com>
---
 conf/vf_vlan.cfg           | 3 +++
 tests/TestSuite_vf_vlan.py | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/conf/vf_vlan.cfg b/conf/vf_vlan.cfg
index 94e68b4..5e0754b 100644
--- a/conf/vf_vlan.cfg
+++ b/conf/vf_vlan.cfg
@@ -1,3 +1,4 @@
+# Configuration sample: sriov_kvm.cfg
 [vm0]
 cpu =
     model=host,number=4,cpupin=5 6 7 8;
@@ -5,7 +6,9 @@ disk =
     file=/storage/vm-image/vm0.img;
 login =
     user=root,password=tester;
+# vnc option is not supported by libvirt yet, comment out below 2 lines if using libvirt
 vnc = 
     displayNum=1;
+# daemon option is not supported by libvirt yet, comment out below 2 lines if using libvirt
 daemon =
     enable=yes;
diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index c0b26a3..da9330d 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -3,7 +3,7 @@
 import re
 import time
 
-from qemu_kvm import QEMUKvm
+from virt_common import VM
 from test_case import TestCase
 from pmd_output import PmdOutput
 from packet import Packet, sniff_packets, load_sniff_packets
@@ -114,7 +114,7 @@ class TestVfVlan(TestCase):
             vf1_prop = {'opt_host': self.sriov_vfs_port_1[0].pci}
 
             # set up VM0 ENV
-            self.vm0 = QEMUKvm(self.dut, 'vm0', 'vf_vlan')
+            self.vm0 = VM(self.dut, 'vm0', 'vf_vlan')
             self.vm0.set_vm_device(driver=self.vf_assign_method, **vf0_prop)
             self.vm0.set_vm_device(driver=self.vf_assign_method, **vf1_prop)
             self.vm_dut_0 = self.vm0.start()
-- 
1.8.3.1

  parent reply	other threads:[~2018-02-12  9:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09  6:25 [dts] [PATCH v1 0/8] " Herbert Guan
2018-02-09  6:25 ` [dts] [PATCH v1 1/8] tests/vf_macfilter: " Herbert Guan
2018-02-09  6:25 ` [dts] [PATCH v1 2/8] tests/vf_jumboframe: " Herbert Guan
2018-02-11 10:07   ` Liu, Yong
2018-02-09  6:26 ` [dts] [PATCH v1 3/8] tests/vf_offload: " Herbert Guan
2018-02-09  6:26 ` [dts] [PATCH v1 4/8] tests/vf_rss: " Herbert Guan
2018-02-09  6:26 ` [dts] [PATCH v1 5/8] tests/vf_to_vf_nic_bridge: " Herbert Guan
2018-02-09  6:26 ` [dts] [PATCH v1 6/8] tests/vf_vlan: " Herbert Guan
2018-02-09  6:26 ` [dts] [PATCH v1 7/8] tests/vf_packet_rxtx: " Herbert Guan
2018-02-09  6:26 ` [dts] [PATCH v1 8/8] tests/vf_port_start_stop: " Herbert Guan
2018-02-12  9:57 ` [dts] [PATCH v2 0/9] " Herbert Guan
2018-02-12  9:57   ` [dts] [PATCH v2 1/9] tests/sriov_kvm: " Herbert Guan
2018-02-12  9:57   ` [dts] [PATCH v2 2/9] tests/vf_port_start_stop: " Herbert Guan
2018-02-12  9:57   ` [dts] [PATCH v2 3/9] tests/vf_packet_rxtx: " Herbert Guan
2018-02-12  9:57   ` Herbert Guan [this message]
2018-02-12  9:57   ` [dts] [PATCH v2 5/9] tests/vf_to_vf_nic_bridge: " Herbert Guan
2018-02-12  9:57   ` [dts] [PATCH v2 6/9] tests/vf_rss: " Herbert Guan
2018-02-12  9:57   ` [dts] [PATCH v2 7/9] tests/vf_offload: " Herbert Guan
2018-02-12  9:57   ` [dts] [PATCH v2 8/9] tests/vf_jumboframe: " Herbert Guan
2018-02-12  9:57   ` [dts] [PATCH v2 9/9] tests/vf_macfilter: " Herbert Guan
2018-02-13 12:45   ` [dts] [PATCH v2 0/9] " Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518429462-30299-5-git-send-email-herbert.guan@arm.com \
    --to=herbert.guan@arm.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).