test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/dynamic_queue: halve the queue number for fvl_40G nic
@ 2018-12-12 10:16 Wenjie Li
  2018-12-12 11:02 ` Lin, Xueqin
  0 siblings, 1 reply; 2+ messages in thread
From: Wenjie Li @ 2018-12-12 10:16 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

For fvl_40G nic, txq cases will fail if the queue number is 64 and could
pass with less queues, so reduce the number.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>

---
 tests/TestSuite_dynamic_queue.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/TestSuite_dynamic_queue.py b/tests/TestSuite_dynamic_queue.py
index f155686..8fc2def 100644
--- a/tests/TestSuite_dynamic_queue.py
+++ b/tests/TestSuite_dynamic_queue.py
@@ -27,6 +27,8 @@ class TestDynamicQueue(TestCase):
         self.dut_testpmd = PmdOutput(self.dut)
 
     def set_up(self):
+        if self.nic in ['fortville_spirit']:
+            self.PF_QUEUE = self.PF_QUEUE / 2
         self.dut_testpmd.start_testpmd(
             "Default", "--port-topology=chained --txq=%s --rxq=%s"
             % (self.PF_QUEUE, self.PF_QUEUE))
-- 
2.17.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/dynamic_queue: halve the queue number for fvl_40G nic
  2018-12-12 10:16 [dts] [PATCH V1] tests/dynamic_queue: halve the queue number for fvl_40G nic Wenjie Li
@ 2018-12-12 11:02 ` Lin, Xueqin
  0 siblings, 0 replies; 2+ messages in thread
From: Lin, Xueqin @ 2018-12-12 11:02 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

Hi Wenjie,

Suggest not decreasing the queue number.
If chang as your patch, queue number will decrease for all FVL 40G, it is not reasonable. 
I can't reproduce it for FVL 40G on my environment, only see it on your environment. 
My concern as below:
1. Basic TX with multi-queues also has the issue, it is not dynamic queue feature special issue.
2. Your CPU is v2, suggest changing other 40G on this sever if has the issue, if yes, means not NIC issue, maybe CPU is too old. 
3. Double check if 10G on this server has the issue. 

Best regards,
Xueqin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Wednesday, December 12, 2018 6:16 PM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/dynamic_queue: halve the queue number for
> fvl_40G nic
> 
> For fvl_40G nic, txq cases will fail if the queue number is 64 and could pass
> with less queues, so reduce the number.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> 
> ---
>  tests/TestSuite_dynamic_queue.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/TestSuite_dynamic_queue.py
> b/tests/TestSuite_dynamic_queue.py
> index f155686..8fc2def 100644
> --- a/tests/TestSuite_dynamic_queue.py
> +++ b/tests/TestSuite_dynamic_queue.py
> @@ -27,6 +27,8 @@ class TestDynamicQueue(TestCase):
>          self.dut_testpmd = PmdOutput(self.dut)
> 
>      def set_up(self):
> +        if self.nic in ['fortville_spirit']:
> +            self.PF_QUEUE = self.PF_QUEUE / 2
>          self.dut_testpmd.start_testpmd(
>              "Default", "--port-topology=chained --txq=%s --rxq=%s"
>              % (self.PF_QUEUE, self.PF_QUEUE))
> --
> 2.17.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-12 11:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-12 10:16 [dts] [PATCH V1] tests/dynamic_queue: halve the queue number for fvl_40G nic Wenjie Li
2018-12-12 11:02 ` Lin, Xueqin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).