From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 70DC42C18 for ; Thu, 7 Mar 2019 08:53:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2019 23:53:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,451,1544515200"; d="scan'208";a="131984891" Received: from dpdk-test60.sh.intel.com ([10.67.111.110]) by orsmga003.jf.intel.com with ESMTP; 06 Mar 2019 23:53:54 -0800 From: Xueqin Lin To: dts@dpdk.org Cc: Xueqin Lin Date: Wed, 6 Mar 2019 20:53:26 -0500 Message-Id: <1551923606-119633-1-git-send-email-xueqin.lin@intel.com> X-Mailer: git-send-email 2.5.5 Subject: [dts] [PATCH] tests/vf_offload: correct case description and delete un-used function X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 07:53:57 -0000 Signed-off-by: Xueqin Lin --- tests/TestSuite_vf_offload.py | 29 +++++++++++------------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py index cb4b368..a327a7e 100644 --- a/tests/TestSuite_vf_offload.py +++ b/tests/TestSuite_vf_offload.py @@ -27,7 +27,7 @@ class TestVfOffload(TestCase): self.vf_driver = self.get_suite_cfg()['vf_driver'] if self.vf_driver is None: self.vf_driver = 'pci-stub' - self.verify(self.vf_driver in self.supported_vf_driver, "Unspported vf driver") + self.verify(self.vf_driver in self.supported_vf_driver, "Unsupported vf driver") if self.vf_driver == 'pci-stub': self.vf_assign_method = 'pci-assign' else: @@ -125,12 +125,6 @@ class TestVfOffload(TestCase): dut.send_expect("csum set sctp hw %d" % port, "testpmd>") dut.send_expect("port start all", "testpmd>") - def checksum_enablesw(self, port, dut): - dut.send_expect("csum set ip sw %d" % port, "testpmd>") - dut.send_expect("csum set udp sw %d" % port, "testpmd>") - dut.send_expect("csum set tcp sw %d" % port, "testpmd>") - dut.send_expect("csum set sctp sw %d" % port, "testpmd>") - def checksum_validate(self, packets_sent, packets_expected): """ Validate the checksum. @@ -202,10 +196,10 @@ class TestVfOffload(TestCase): def test_checksum_offload_enable(self): """ - Enable HW Checksum offload. - Send packet with incorrect checksum, - can rx it and reported the checksum error, - verify forwarded packets have correct checksum + Enable HW checksum offload. + Send packet with incorrect checksum, + can rx it and report the checksum error, + verify forwarded packets have correct checksum. """ self.vm0_testpmd.start_testpmd(VM_CORES_MASK, "--portmask=%s " % (self.portMask) + "--enable-rx-cksum " + "" + @@ -252,8 +246,7 @@ class TestVfOffload(TestCase): def test_checksum_offload_disable(self): """ - disable HW checksum offload on tx port, SW Checksum check. - SW Checksum on by default. + Default checksum is SW or enable SW checksum similar to HW checksum. Send same packet with incorrect checksum and verify checksum is valid. """ @@ -293,7 +286,7 @@ class TestVfOffload(TestCase): def tcpdump_start_sniffing(self, ifaces=[]): """ - Starts tcpdump in the background to sniff the tester interface where + Start tcpdump in the background to sniff the tester interface where the packets are transmitted to and from the self.dut. All the captured packets are going to be stored in a file for a post-analysis. @@ -306,7 +299,7 @@ class TestVfOffload(TestCase): def tcpdump_stop_sniff(self): """ - Stops the tcpdump process running in the background. + Stop the tcpdump process running in the background. """ self.tester.send_expect('killall tcpdump', '#') time.sleep(1) @@ -315,7 +308,7 @@ class TestVfOffload(TestCase): def tcpdump_command(self, command): """ - Sends a tcpdump related command and returns an integer from the output + Send a tcpdump related command and return an integer from the output. """ result = self.tester.send_expect(command, '#') @@ -324,7 +317,7 @@ class TestVfOffload(TestCase): def number_of_packets(self, iface): """ - By reading the file generated by tcpdump it counts how many packets were + By reading the file generated by tcpdump it counts how many packets are forwarded by the sample app and received in the self.tester. The sample app will add a known MAC address for the test to look for. """ @@ -335,7 +328,7 @@ class TestVfOffload(TestCase): def test_tso(self): """ - TSO IPv4 TCP, IPv6 TCP, VXLan testing + TSO IPv4 TCP, IPv6 TCP testing """ tx_interface = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0])) rx_interface = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[1])) -- 2.5.5