From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CB9D8A0662 for ; Mon, 18 Mar 2019 10:58:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE02811A4; Mon, 18 Mar 2019 10:58:22 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 3C274A3 for ; Mon, 18 Mar 2019 10:58:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Mar 2019 02:58:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,493,1544515200"; d="scan'208";a="308131002" Received: from dpdk-test60.sh.intel.com ([10.67.111.110]) by orsmga005.jf.intel.com with ESMTP; 18 Mar 2019 02:58:19 -0700 From: Xueqin Lin To: dts@dpdk.org Cc: Xueqin Lin Date: Sun, 17 Mar 2019 23:57:59 -0400 Message-Id: <1552881479-115103-1-git-send-email-xueqin.lin@intel.com> X-Mailer: git-send-email 2.5.5 Subject: [dts] [PATCH] tests/vf_offload: correct case grammar and sw checksum test X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Signed-off-by: Xueqin Lin --- tests/TestSuite_vf_offload.py | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py index cb4b368..8cb0dac 100644 --- a/tests/TestSuite_vf_offload.py +++ b/tests/TestSuite_vf_offload.py @@ -27,7 +27,7 @@ class TestVfOffload(TestCase): self.vf_driver = self.get_suite_cfg()['vf_driver'] if self.vf_driver is None: self.vf_driver = 'pci-stub' - self.verify(self.vf_driver in self.supported_vf_driver, "Unspported vf driver") + self.verify(self.vf_driver in self.supported_vf_driver, "Unsupported vf driver") if self.vf_driver == 'pci-stub': self.vf_assign_method = 'pci-assign' else: @@ -126,10 +126,12 @@ class TestVfOffload(TestCase): dut.send_expect("port start all", "testpmd>") def checksum_enablesw(self, port, dut): + dut.send_expect("port stop all", "testpmd>") dut.send_expect("csum set ip sw %d" % port, "testpmd>") dut.send_expect("csum set udp sw %d" % port, "testpmd>") dut.send_expect("csum set tcp sw %d" % port, "testpmd>") dut.send_expect("csum set sctp sw %d" % port, "testpmd>") + dut.send_expect("port start all", "testpmd>") def checksum_validate(self, packets_sent, packets_expected): """ @@ -202,10 +204,10 @@ class TestVfOffload(TestCase): def test_checksum_offload_enable(self): """ - Enable HW Checksum offload. - Send packet with incorrect checksum, - can rx it and reported the checksum error, - verify forwarded packets have correct checksum + Enable HW checksum offload. + Send packet with incorrect checksum, + can rx it and report the checksum error, + verify forwarded packets have correct checksum. """ self.vm0_testpmd.start_testpmd(VM_CORES_MASK, "--portmask=%s " % (self.portMask) + "--enable-rx-cksum " + "" + @@ -252,8 +254,7 @@ class TestVfOffload(TestCase): def test_checksum_offload_disable(self): """ - disable HW checksum offload on tx port, SW Checksum check. - SW Checksum on by default. + Enable SW checksum offload. Send same packet with incorrect checksum and verify checksum is valid. """ @@ -279,6 +280,8 @@ class TestVfOffload(TestCase): 'IPv6/UDP': 'Ether(dst="02:00:00:00:00:00", src="%s")/IPv6(src="%s")/UDP()/("X"*46)' % (mac, expIPv6), 'IPv6/TCP': 'Ether(dst="02:00:00:00:00:00", src="%s")/IPv6(src="%s")/TCP()/("X"*46)' % (mac, expIPv6)} + self.checksum_enablesw(0, self.vm_dut_0) + self.vm0_testpmd.execute_cmd('start') result = self.checksum_validate(sndPkts, expPkts) @@ -293,7 +296,7 @@ class TestVfOffload(TestCase): def tcpdump_start_sniffing(self, ifaces=[]): """ - Starts tcpdump in the background to sniff the tester interface where + Start tcpdump in the background to sniff the tester interface where the packets are transmitted to and from the self.dut. All the captured packets are going to be stored in a file for a post-analysis. @@ -306,7 +309,7 @@ class TestVfOffload(TestCase): def tcpdump_stop_sniff(self): """ - Stops the tcpdump process running in the background. + Stop the tcpdump process running in the background. """ self.tester.send_expect('killall tcpdump', '#') time.sleep(1) @@ -315,7 +318,7 @@ class TestVfOffload(TestCase): def tcpdump_command(self, command): """ - Sends a tcpdump related command and returns an integer from the output + Send a tcpdump related command and return an integer from the output. """ result = self.tester.send_expect(command, '#') @@ -324,7 +327,7 @@ class TestVfOffload(TestCase): def number_of_packets(self, iface): """ - By reading the file generated by tcpdump it counts how many packets were + By reading the file generated by tcpdump it counts how many packets are forwarded by the sample app and received in the self.tester. The sample app will add a known MAC address for the test to look for. """ @@ -335,7 +338,7 @@ class TestVfOffload(TestCase): def test_tso(self): """ - TSO IPv4 TCP, IPv6 TCP, VXLan testing + TSO IPv4 TCP, IPv6 TCP testing. """ tx_interface = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0])) rx_interface = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[1])) -- 2.5.5