test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] framework/project_dpdk:delete the specified compiler of freebsd
@ 2019-03-26  8:32 changqingxwu
  2019-03-26  9:35 ` Zhu, ShuaiX
  2019-04-03 17:04 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: changqingxwu @ 2019-03-26  8:32 UTC (permalink / raw)
  To: dts; +Cc: changqingxwu

Signed-off-by: changqingxwu <changqingx.wu@intel.com>
---
 framework/project_dpdk.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
index 6035c68..bc26f55 100644
--- a/framework/project_dpdk.py
+++ b/framework/project_dpdk.py
@@ -236,13 +236,13 @@ class DPDKdut(Dut):
         self.send_expect("rm -rf %s" % r'./app/test/test_pci_sysfs.res.o' , "#")
         build_time = 120
         # compile
-        out = self.send_expect("make -j %d install T=%s CC=gcc48" % (self.number_of_cores,
+        out = self.send_expect("make -j %d install T=%s" % (self.number_of_cores,
                                                                      target),
                                "#", build_time)
         if("Error" in out or "No rule to make" in out):
             self.logger.error("ERROR - try without '-j'")
             # if Error try to execute make without -j option
-            out = self.send_expect("make install T=%s CC=gcc48" % target,
+            out = self.send_expect("make install T=%s" % target,
                                    "#", build_time)
 
         assert ("Error" not in out), "Compilation error..."
-- 
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] framework/project_dpdk:delete the specified compiler of freebsd
  2019-03-26  8:32 [dts] [PATCH V1] framework/project_dpdk:delete the specified compiler of freebsd changqingxwu
@ 2019-03-26  9:35 ` Zhu, ShuaiX
  2019-04-03 17:04 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, ShuaiX @ 2019-03-26  9:35 UTC (permalink / raw)
  To: Wu, ChangqingX, dts; +Cc: Wu, ChangqingX, Zhu, ShuaiX

Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Tuesday, March 26, 2019 4:32 PM
> To: dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V1] framework/project_dpdk:delete the specified
> compiler of freebsd
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  framework/project_dpdk.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py index
> 6035c68..bc26f55 100644
> --- a/framework/project_dpdk.py
> +++ b/framework/project_dpdk.py
> @@ -236,13 +236,13 @@ class DPDKdut(Dut):
>          self.send_expect("rm -rf %s" % r'./app/test/test_pci_sysfs.res.o' ,
> "#")
>          build_time = 120
>          # compile
> -        out = self.send_expect("make -j %d install T=%s CC=gcc48" %
> (self.number_of_cores,
> +        out = self.send_expect("make -j %d install T=%s" %
> + (self.number_of_cores,
> 
> target),
>                                 "#", build_time)
>          if("Error" in out or "No rule to make" in out):
>              self.logger.error("ERROR - try without '-j'")
>              # if Error try to execute make without -j option
> -            out = self.send_expect("make install T=%s CC=gcc48" % target,
> +            out = self.send_expect("make install T=%s" % target,
>                                     "#", build_time)
> 
>          assert ("Error" not in out), "Compilation error..."
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] framework/project_dpdk:delete the specified compiler of freebsd
  2019-03-26  8:32 [dts] [PATCH V1] framework/project_dpdk:delete the specified compiler of freebsd changqingxwu
  2019-03-26  9:35 ` Zhu, ShuaiX
@ 2019-04-03 17:04 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-04-03 17:04 UTC (permalink / raw)
  To: Wu, ChangqingX, dts; +Cc: Wu, ChangqingX

If you submit the V2, Could you please change your version tag to v2, I take the patch are the same if there are the same version tag.

Still miss a line of gcc48, 
239:        out = self.send_expect("make -j %d install T=%s CC=gcc48" % (self.number_of_cores,

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Tuesday, March 26, 2019 1:32 AM
> To: dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V1] framework/project_dpdk:delete the specified
> compiler of freebsd
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  framework/project_dpdk.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py index
> 6035c68..bc26f55 100644
> --- a/framework/project_dpdk.py
> +++ b/framework/project_dpdk.py
> @@ -236,13 +236,13 @@ class DPDKdut(Dut):
>          self.send_expect("rm -rf %s" % r'./app/test/test_pci_sysfs.res.o' , "#")
>          build_time = 120
>          # compile
> -        out = self.send_expect("make -j %d install T=%s CC=gcc48" %
> (self.number_of_cores,
> +        out = self.send_expect("make -j %d install T=%s" %
> + (self.number_of_cores,
>                                                                       target),
>                                 "#", build_time)
>          if("Error" in out or "No rule to make" in out):
>              self.logger.error("ERROR - try without '-j'")
>              # if Error try to execute make without -j option
> -            out = self.send_expect("make install T=%s CC=gcc48" % target,
> +            out = self.send_expect("make install T=%s" % target,
>                                     "#", build_time)
> 
>          assert ("Error" not in out), "Compilation error..."
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-03 17:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-26  8:32 [dts] [PATCH V1] framework/project_dpdk:delete the specified compiler of freebsd changqingxwu
2019-03-26  9:35 ` Zhu, ShuaiX
2019-04-03 17:04 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).