From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F41C6A0679 for ; Fri, 29 Mar 2019 07:00:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C7243256; Fri, 29 Mar 2019 07:00:58 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id ABC8B1DB8 for ; Fri, 29 Mar 2019 07:00:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 23:00:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,283,1549958400"; d="scan'208";a="218659778" Received: from unknown (HELO localhost.localdomain.sh.intel.com) ([10.240.176.135]) by orsmga001.jf.intel.com with ESMTP; 28 Mar 2019 23:00:55 -0700 From: "xiao,qimai" To: dts@dpdk.org Cc: zhuwenhui Date: Fri, 29 Mar 2019 14:04:55 +0800 Message-Id: <1553839495-91306-1-git-send-email-qimaix.xiao@intel.com> X-Mailer: git-send-email 1.9.3 Subject: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" From: zhuwenhui Set the mtu to 2048. First "stop port_id", then "open port_id" The second package pkt_size needs to be added HEADER_SIZE['eth'] Signed-off-by: zhuwenhui --- tests/TestSuite_userspace_ethtool.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py index 4208e0f..060529e 100644 --- a/tests/TestSuite_userspace_ethtool.py +++ b/tests/TestSuite_userspace_ethtool.py @@ -556,16 +556,18 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator): self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# ") for mtu in mtus: self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>") + self.dut.send_expect("open %s" % index, "EthApp>") ori_rx_pkts, _ = self.strip_portstats(index) pkt_size = mtu + HEADER_SIZE['eth'] pkt = Packet(pkt_len=pkt_size) pkt.send_pkt(tx_port=intf) rx_pkts, _ = self.strip_portstats(index) - self.verify(rx_pkts == ori_rx_pkts, "Packet match mtu not forwarded as expected") - pkt = Packet(pkt_len=mtu + 1) + self.verify(rx_pkts == ori_rx_pkts + 1, "Packet match mtu not forwarded as expected") + pkt = Packet(pkt_len=mtu + 1 + HEADER_SIZE['eth']) pkt.send_pkt(tx_port=intf) rx_pkts_over, _ = self.strip_portstats(index) self.verify(rx_pkts == rx_pkts_over, "Packet over mtu should not be forwarded") + self.dut.send_expect("stop %s" % index, "EthApp>") self.tester.send_expect("ifconfig %s mtu %d" % (intf, ori_mtu), "# ") -- 2.17.2