* [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions
@ 2019-03-29 6:04 xiao,qimai
0 siblings, 0 replies; 6+ messages in thread
From: xiao,qimai @ 2019-03-29 6:04 UTC (permalink / raw)
To: dts; +Cc: zhuwenhui
From: zhuwenhui <wenhuix.zhu@intel.com>
Set the mtu to 2048. First "stop port_id", then "open port_id"
The second package pkt_size needs to be added HEADER_SIZE['eth']
Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
---
tests/TestSuite_userspace_ethtool.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 4208e0f..060529e 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -556,16 +556,18 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# ")
for mtu in mtus:
self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
+ self.dut.send_expect("open %s" % index, "EthApp>")
ori_rx_pkts, _ = self.strip_portstats(index)
pkt_size = mtu + HEADER_SIZE['eth']
pkt = Packet(pkt_len=pkt_size)
pkt.send_pkt(tx_port=intf)
rx_pkts, _ = self.strip_portstats(index)
- self.verify(rx_pkts == ori_rx_pkts, "Packet match mtu not forwarded as expected")
- pkt = Packet(pkt_len=mtu + 1)
+ self.verify(rx_pkts == ori_rx_pkts + 1, "Packet match mtu not forwarded as expected")
+ pkt = Packet(pkt_len=mtu + 1 + HEADER_SIZE['eth'])
pkt.send_pkt(tx_port=intf)
rx_pkts_over, _ = self.strip_portstats(index)
self.verify(rx_pkts == rx_pkts_over, "Packet over mtu should not be forwarded")
+ self.dut.send_expect("stop %s" % index, "EthApp>")
self.tester.send_expect("ifconfig %s mtu %d" % (intf, ori_mtu), "# ")
--
2.17.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions
@ 2019-03-29 6:09 zhuwenhui
2019-03-29 8:18 ` Yao, BingX Y
2019-03-31 4:07 ` Tu, Lijuan
0 siblings, 2 replies; 6+ messages in thread
From: zhuwenhui @ 2019-03-29 6:09 UTC (permalink / raw)
To: dts; +Cc: zhuwenhui
Set the mtu to 2048. First "stop port_id", then "open port_id"
The second package pkt_size needs to be added HEADER_SIZE['eth']
Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
---
tests/TestSuite_userspace_ethtool.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 4208e0f..060529e 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -556,16 +556,18 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# ")
for mtu in mtus:
self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
+ self.dut.send_expect("open %s" % index, "EthApp>")
ori_rx_pkts, _ = self.strip_portstats(index)
pkt_size = mtu + HEADER_SIZE['eth']
pkt = Packet(pkt_len=pkt_size)
pkt.send_pkt(tx_port=intf)
rx_pkts, _ = self.strip_portstats(index)
- self.verify(rx_pkts == ori_rx_pkts, "Packet match mtu not forwarded as expected")
- pkt = Packet(pkt_len=mtu + 1)
+ self.verify(rx_pkts == ori_rx_pkts + 1, "Packet match mtu not forwarded as expected")
+ pkt = Packet(pkt_len=mtu + 1 + HEADER_SIZE['eth'])
pkt.send_pkt(tx_port=intf)
rx_pkts_over, _ = self.strip_portstats(index)
self.verify(rx_pkts == rx_pkts_over, "Packet over mtu should not be forwarded")
+ self.dut.send_expect("stop %s" % index, "EthApp>")
self.tester.send_expect("ifconfig %s mtu %d" % (intf, ori_mtu), "# ")
--
2.17.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions
2019-03-29 6:09 zhuwenhui
@ 2019-03-29 8:18 ` Yao, BingX Y
2019-03-31 4:07 ` Tu, Lijuan
1 sibling, 0 replies; 6+ messages in thread
From: Yao, BingX Y @ 2019-03-29 8:18 UTC (permalink / raw)
To: Zhu, WenhuiX, dts; +Cc: Zhu, WenhuiX
Tested-by: Yao, BingX Y <bingx.y.yao@intel.com>
-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui
Sent: Friday, March 29, 2019 2:10 PM
To: dts@dpdk.org
Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
Subject: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions
Set the mtu to 2048. First "stop port_id", then "open port_id"
The second package pkt_size needs to be added HEADER_SIZE['eth']
Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
---
tests/TestSuite_userspace_ethtool.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 4208e0f..060529e 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -556,16 +556,18 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# ")
for mtu in mtus:
self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
+ self.dut.send_expect("open %s" % index, "EthApp>")
ori_rx_pkts, _ = self.strip_portstats(index)
pkt_size = mtu + HEADER_SIZE['eth']
pkt = Packet(pkt_len=pkt_size)
pkt.send_pkt(tx_port=intf)
rx_pkts, _ = self.strip_portstats(index)
- self.verify(rx_pkts == ori_rx_pkts, "Packet match mtu not forwarded as expected")
- pkt = Packet(pkt_len=mtu + 1)
+ self.verify(rx_pkts == ori_rx_pkts + 1, "Packet match mtu not forwarded as expected")
+ pkt = Packet(pkt_len=mtu + 1 + HEADER_SIZE['eth'])
pkt.send_pkt(tx_port=intf)
rx_pkts_over, _ = self.strip_portstats(index)
self.verify(rx_pkts == rx_pkts_over, "Packet over mtu should not be forwarded")
+ self.dut.send_expect("stop %s" % index, "EthApp>")
self.tester.send_expect("ifconfig %s mtu %d" % (intf, ori_mtu), "# ")
--
2.17.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions
2019-03-29 6:09 zhuwenhui
2019-03-29 8:18 ` Yao, BingX Y
@ 2019-03-31 4:07 ` Tu, Lijuan
2019-04-01 1:14 ` Zhu, WenhuiX
1 sibling, 1 reply; 6+ messages in thread
From: Tu, Lijuan @ 2019-03-31 4:07 UTC (permalink / raw)
To: Zhu, WenhuiX, dts; +Cc: Zhu, WenhuiX
Is this a new issue found in 19.05? if the answer is yes, which commit changed ?
As your commets, only 2048 require to open/stop port, does other mtu need to do that?
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui
> Sent: Thursday, March 28, 2019 11:10 PM
> To: dts@dpdk.org
> Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment
> conditions
>
> Set the mtu to 2048. First "stop port_id", then "open port_id"
> The second package pkt_size needs to be added HEADER_SIZE['eth']
>
> Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
> ---
> tests/TestSuite_userspace_ethtool.py | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 4208e0f..060529e 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -556,16 +556,18 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
> self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# ")
> for mtu in mtus:
> self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
> + self.dut.send_expect("open %s" % index, "EthApp>")
> ori_rx_pkts, _ = self.strip_portstats(index)
> pkt_size = mtu + HEADER_SIZE['eth']
> pkt = Packet(pkt_len=pkt_size)
> pkt.send_pkt(tx_port=intf)
> rx_pkts, _ = self.strip_portstats(index)
> - self.verify(rx_pkts == ori_rx_pkts, "Packet match mtu not
> forwarded as expected")
> - pkt = Packet(pkt_len=mtu + 1)
> + self.verify(rx_pkts == ori_rx_pkts + 1, "Packet match mtu not
> forwarded as expected")
> + pkt = Packet(pkt_len=mtu + 1 + HEADER_SIZE['eth'])
> pkt.send_pkt(tx_port=intf)
> rx_pkts_over, _ = self.strip_portstats(index)
> self.verify(rx_pkts == rx_pkts_over, "Packet over mtu should not be
> forwarded")
> + self.dut.send_expect("stop %s" % index, "EthApp>")
>
> self.tester.send_expect("ifconfig %s mtu %d" % (intf, ori_mtu), "# ")
>
> --
> 2.17.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions
2019-03-31 4:07 ` Tu, Lijuan
@ 2019-04-01 1:14 ` Zhu, WenhuiX
2019-04-03 17:27 ` Tu, Lijuan
0 siblings, 1 reply; 6+ messages in thread
From: Zhu, WenhuiX @ 2019-04-01 1:14 UTC (permalink / raw)
To: Tu, Lijuan, dts
Hi lijuan,
1. This is not a recent one, it has been there before.
2. The threshold is 2022. When it is greater than 2022, the open/stop port is required.
BR,
Wenhui.
-----Original Message-----
From: Tu, Lijuan
Sent: Sunday, March 31, 2019 12:07 PM
To: Zhu, WenhuiX <wenhuix.zhu@intel.com>; dts@dpdk.org
Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
Subject: RE: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions
Is this a new issue found in 19.05? if the answer is yes, which commit changed ?
As your commets, only 2048 require to open/stop port, does other mtu need to do that?
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui
> Sent: Thursday, March 28, 2019 11:10 PM
> To: dts@dpdk.org
> Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment
> conditions
>
> Set the mtu to 2048. First "stop port_id", then "open port_id"
> The second package pkt_size needs to be added HEADER_SIZE['eth']
>
> Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
> ---
> tests/TestSuite_userspace_ethtool.py | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 4208e0f..060529e 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -556,16 +556,18 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
> self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# ")
> for mtu in mtus:
> self.dut.send_expect("mtu %d %d" % (index, mtu),
> "EthApp>")
> + self.dut.send_expect("open %s" % index, "EthApp>")
> ori_rx_pkts, _ = self.strip_portstats(index)
> pkt_size = mtu + HEADER_SIZE['eth']
> pkt = Packet(pkt_len=pkt_size)
> pkt.send_pkt(tx_port=intf)
> rx_pkts, _ = self.strip_portstats(index)
> - self.verify(rx_pkts == ori_rx_pkts, "Packet match mtu not
> forwarded as expected")
> - pkt = Packet(pkt_len=mtu + 1)
> + self.verify(rx_pkts == ori_rx_pkts + 1, "Packet match
> + mtu not
> forwarded as expected")
> + pkt = Packet(pkt_len=mtu + 1 + HEADER_SIZE['eth'])
> pkt.send_pkt(tx_port=intf)
> rx_pkts_over, _ = self.strip_portstats(index)
> self.verify(rx_pkts == rx_pkts_over, "Packet over mtu
> should not be
> forwarded")
> + self.dut.send_expect("stop %s" % index, "EthApp>")
>
> self.tester.send_expect("ifconfig %s mtu %d" % (intf,
> ori_mtu), "# ")
>
> --
> 2.17.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions
2019-04-01 1:14 ` Zhu, WenhuiX
@ 2019-04-03 17:27 ` Tu, Lijuan
0 siblings, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2019-04-03 17:27 UTC (permalink / raw)
To: Zhu, WenhuiX, dts
> -----Original Message-----
> From: Zhu, WenhuiX
> Sent: Sunday, March 31, 2019 6:14 PM
> To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment
> conditions
>
> Hi lijuan,
>
> 1. This is not a recent one, it has been there before.
> 2. The threshold is 2022. When it is greater than 2022, the open/stop port is
> required.
[Lijuan] Could your kindly to add a static variable to point to the threshold, so that readers could understand why is 2048. Some interpretation will be great.
>
> BR,
> Wenhui.
> -----Original Message-----
> From: Tu, Lijuan
> Sent: Sunday, March 31, 2019 12:07 PM
> To: Zhu, WenhuiX <wenhuix.zhu@intel.com>; dts@dpdk.org
> Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment
> conditions
>
> Is this a new issue found in 19.05? if the answer is yes, which commit
> changed ?
>
> As your commets, only 2048 require to open/stop port, does other mtu need
> to do that?
>
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui
> > Sent: Thursday, March 28, 2019 11:10 PM
> > To: dts@dpdk.org
> > Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
> > Subject: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment
> > conditions
> >
> > Set the mtu to 2048. First "stop port_id", then "open port_id"
> > The second package pkt_size needs to be added HEADER_SIZE['eth']
> >
> > Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
> > ---
> > tests/TestSuite_userspace_ethtool.py | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/TestSuite_userspace_ethtool.py
> > b/tests/TestSuite_userspace_ethtool.py
> > index 4208e0f..060529e 100644
> > --- a/tests/TestSuite_userspace_ethtool.py
> > +++ b/tests/TestSuite_userspace_ethtool.py
> > @@ -556,16 +556,18 @@ class TestUserspaceEthtool(TestCase,
> > IxiaPacketGenerator):
> > self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# ")
> > for mtu in mtus:
> > self.dut.send_expect("mtu %d %d" % (index, mtu),
> > "EthApp>")
> > + self.dut.send_expect("open %s" % index, "EthApp>")
> > ori_rx_pkts, _ = self.strip_portstats(index)
> > pkt_size = mtu + HEADER_SIZE['eth']
> > pkt = Packet(pkt_len=pkt_size)
> > pkt.send_pkt(tx_port=intf)
> > rx_pkts, _ = self.strip_portstats(index)
> > - self.verify(rx_pkts == ori_rx_pkts, "Packet match mtu not
> > forwarded as expected")
> > - pkt = Packet(pkt_len=mtu + 1)
> > + self.verify(rx_pkts == ori_rx_pkts + 1, "Packet match
> > + mtu not
> > forwarded as expected")
> > + pkt = Packet(pkt_len=mtu + 1 + HEADER_SIZE['eth'])
> > pkt.send_pkt(tx_port=intf)
> > rx_pkts_over, _ = self.strip_portstats(index)
> > self.verify(rx_pkts == rx_pkts_over, "Packet over mtu
> > should not be
> > forwarded")
> > + self.dut.send_expect("stop %s" % index, "EthApp>")
> >
> > self.tester.send_expect("ifconfig %s mtu %d" % (intf,
> > ori_mtu), "# ")
> >
> > --
> > 2.17.2
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-03 17:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-29 6:04 [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions xiao,qimai
2019-03-29 6:09 zhuwenhui
2019-03-29 8:18 ` Yao, BingX Y
2019-03-31 4:07 ` Tu, Lijuan
2019-04-01 1:14 ` Zhu, WenhuiX
2019-04-03 17:27 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).