test suite reviews and discussions
 help / color / mirror / Atom feed
From: zhuwenhui <wenhuix.zhu@intel.com>
To: dts@dpdk.org
Cc: zhuwenhui <wenhuix.zhu@intel.com>
Subject: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions
Date: Fri, 29 Mar 2019 14:09:59 +0800	[thread overview]
Message-ID: <1553839799-91625-1-git-send-email-wenhuix.zhu@intel.com> (raw)

Set the mtu to 2048. First "stop port_id", then "open port_id"
The second package pkt_size needs to be added HEADER_SIZE['eth']

Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 4208e0f..060529e 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -556,16 +556,18 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
             self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# ")
             for mtu in mtus:
                 self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
+                self.dut.send_expect("open %s" % index, "EthApp>")
                 ori_rx_pkts, _ = self.strip_portstats(index)
                 pkt_size = mtu + HEADER_SIZE['eth']
                 pkt = Packet(pkt_len=pkt_size)
                 pkt.send_pkt(tx_port=intf)
                 rx_pkts, _ = self.strip_portstats(index)
-                self.verify(rx_pkts == ori_rx_pkts, "Packet match mtu not forwarded as expected")
-                pkt = Packet(pkt_len=mtu + 1)
+                self.verify(rx_pkts == ori_rx_pkts + 1, "Packet match mtu not forwarded as expected")
+                pkt = Packet(pkt_len=mtu + 1 + HEADER_SIZE['eth']) 
                 pkt.send_pkt(tx_port=intf)
                 rx_pkts_over, _ = self.strip_portstats(index)
                 self.verify(rx_pkts == rx_pkts_over, "Packet over mtu should not be forwarded")
+                self.dut.send_expect("stop %s" % index, "EthApp>")
 
             self.tester.send_expect("ifconfig %s mtu %d" % (intf, ori_mtu), "# ")
 
-- 
2.17.2


             reply	other threads:[~2019-03-29  6:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29  6:09 zhuwenhui [this message]
2019-03-29  8:18 ` Yao, BingX Y
2019-03-31  4:07 ` Tu, Lijuan
2019-04-01  1:14   ` Zhu, WenhuiX
2019-04-03 17:27     ` Tu, Lijuan
  -- strict thread matches above, loose matches on Subject: below --
2019-03-29  6:04 xiao,qimai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1553839799-91625-1-git-send-email-wenhuix.zhu@intel.com \
    --to=wenhuix.zhu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).