test suite reviews and discussions
 help / color / mirror / Atom feed
From: zhuwenhui <wenhuix.zhu@intel.com>
To: dts@dpdk.org
Cc: zhuwenhui <wenhuix.zhu@intel.com>
Subject: [dts] [PATCH V2] tests/userspace_ethtool Modify judgment conditions
Date: Tue,  9 Apr 2019 11:39:29 +0800	[thread overview]
Message-ID: <1554781169-14153-1-git-send-email-wenhuix.zhu@intel.com> (raw)

The second package pkt_size needs to be added HEADER_SIZE['eth'].
The mtu threshold is 2022, when mtu is over 2022,require to open/stop port


Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 4208e0f..f8428ea 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -547,6 +547,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         """
         self.dut.send_expect(self.cmd, "EthApp>", 60)
         mtus = [1519, 2048]
+        mtu_threshold = 2022
         for index in range(len(self.ports)):
             port = self.ports[index]
             # change mtu
@@ -555,14 +556,19 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
             ori_mtu = self.strip_mtu(intf)
             self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# ")
             for mtu in mtus:
+                # The mtu threshold is 2022,When it is greater than 2022, the open/stop port is required.
+                if mtu > mtu_threshold:
+                    self.dut.send_expect("stop %s" % index, "EthApp>")
+                    self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
+                    self.dut.send_expect("open %s" % index, "EthApp>")
                 self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
                 ori_rx_pkts, _ = self.strip_portstats(index)
                 pkt_size = mtu + HEADER_SIZE['eth']
                 pkt = Packet(pkt_len=pkt_size)
                 pkt.send_pkt(tx_port=intf)
                 rx_pkts, _ = self.strip_portstats(index)
-                self.verify(rx_pkts == ori_rx_pkts, "Packet match mtu not forwarded as expected")
-                pkt = Packet(pkt_len=mtu + 1)
+                self.verify(rx_pkts == ori_rx_pkts + 1, "Packet match mtu not forwarded as expected")
+                pkt = Packet(pkt_len=mtu + 1 + HEADER_SIZE['eth'])
                 pkt.send_pkt(tx_port=intf)
                 rx_pkts_over, _ = self.strip_portstats(index)
                 self.verify(rx_pkts == rx_pkts_over, "Packet over mtu should not be forwarded")
-- 
2.17.2


             reply	other threads:[~2019-04-09  3:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09  3:39 zhuwenhui [this message]
2019-04-09  5:11 ` Yao, BingX Y
2019-04-15 19:55 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1554781169-14153-1-git-send-email-wenhuix.zhu@intel.com \
    --to=wenhuix.zhu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).