From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3141AA0096 for ; Tue, 9 Apr 2019 05:35:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 249BD4D27; Tue, 9 Apr 2019 05:35:20 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D7FA94CC3 for ; Tue, 9 Apr 2019 05:35:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 20:35:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,327,1549958400"; d="scan'208";a="159449851" Received: from unknown (HELO localhost.localdomain.sh.intel.com) ([10.240.176.135]) by fmsmga002.fm.intel.com with ESMTP; 08 Apr 2019 20:35:16 -0700 From: zhuwenhui To: dts@dpdk.org Cc: zhuwenhui Date: Tue, 9 Apr 2019 11:39:29 +0800 Message-Id: <1554781169-14153-1-git-send-email-wenhuix.zhu@intel.com> X-Mailer: git-send-email 1.9.3 Subject: [dts] [PATCH V2] tests/userspace_ethtool Modify judgment conditions X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" The second package pkt_size needs to be added HEADER_SIZE['eth']. The mtu threshold is 2022, when mtu is over 2022,require to open/stop port Signed-off-by: zhuwenhui --- tests/TestSuite_userspace_ethtool.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py index 4208e0f..f8428ea 100644 --- a/tests/TestSuite_userspace_ethtool.py +++ b/tests/TestSuite_userspace_ethtool.py @@ -547,6 +547,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator): """ self.dut.send_expect(self.cmd, "EthApp>", 60) mtus = [1519, 2048] + mtu_threshold = 2022 for index in range(len(self.ports)): port = self.ports[index] # change mtu @@ -555,14 +556,19 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator): ori_mtu = self.strip_mtu(intf) self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# ") for mtu in mtus: + # The mtu threshold is 2022,When it is greater than 2022, the open/stop port is required. + if mtu > mtu_threshold: + self.dut.send_expect("stop %s" % index, "EthApp>") + self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>") + self.dut.send_expect("open %s" % index, "EthApp>") self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>") ori_rx_pkts, _ = self.strip_portstats(index) pkt_size = mtu + HEADER_SIZE['eth'] pkt = Packet(pkt_len=pkt_size) pkt.send_pkt(tx_port=intf) rx_pkts, _ = self.strip_portstats(index) - self.verify(rx_pkts == ori_rx_pkts, "Packet match mtu not forwarded as expected") - pkt = Packet(pkt_len=mtu + 1) + self.verify(rx_pkts == ori_rx_pkts + 1, "Packet match mtu not forwarded as expected") + pkt = Packet(pkt_len=mtu + 1 + HEADER_SIZE['eth']) pkt.send_pkt(tx_port=intf) rx_pkts_over, _ = self.strip_portstats(index) self.verify(rx_pkts == rx_pkts_over, "Packet over mtu should not be forwarded") -- 2.17.2