* [dts] [PATCH V2] vxlan:Optimization check inner l4 invalid
@ 2019-04-15 9:56 changqingxwu
2019-04-15 20:39 ` Tu, Lijuan
0 siblings, 1 reply; 2+ messages in thread
From: changqingxwu @ 2019-04-15 9:56 UTC (permalink / raw)
To: dts; +Cc: changqingxwu
resetting 'rx_bad_*' stats after stop, this is consistent behavior
with rest of the stats. It is not necessary to accumulate the results
of Bad-l4csum after each stop.
Signed-off-by: changqingxwu <changqingx.wu@intel.com>
---
tests/TestSuite_vxlan.py | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
index 8de8384..b4b852f 100644
--- a/tests/TestSuite_vxlan.py
+++ b/tests/TestSuite_vxlan.py
@@ -468,8 +468,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
# verify detected l4 invalid checksum
if "inner_l4_invalid" in kwargs:
self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out)
- == self.l4err_num + 1, "Failed to count inner l4 chksum error")
- self.l4err_num += 1
+ == 1, "Failed to count inner l4 chksum error")
# verify detected l3 invalid checksum
if "ip_invalid" in kwargs:
@@ -649,7 +648,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
'PORT': self.portMask}
self.dut.send_expect(pmd_cmd, "testpmd>", 30)
self.iperr_num = 0
- self.l4err_num = 0
# disable vlan filter
self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
@@ -724,7 +722,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
'PORT': self.portMask}
self.dut.send_expect(pmd_cmd, "testpmd>", 30)
self.iperr_num = 0
- self.l4err_num = 0
# disable vlan filter
self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
--
2.17.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [PATCH V2] vxlan:Optimization check inner l4 invalid
2019-04-15 9:56 [dts] [PATCH V2] vxlan:Optimization check inner l4 invalid changqingxwu
@ 2019-04-15 20:39 ` Tu, Lijuan
0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-04-15 20:39 UTC (permalink / raw)
To: Wu, ChangqingX, dts; +Cc: Wu, ChangqingX
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Monday, April 15, 2019 2:56 AM
> To: dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V2] vxlan:Optimization check inner l4 invalid
>
> resetting 'rx_bad_*' stats after stop, this is consistent behavior with rest of
> the stats. It is not necessary to accumulate the results of Bad-l4csum after
> each stop.
>
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
> tests/TestSuite_vxlan.py | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index
> 8de8384..b4b852f 100644
> --- a/tests/TestSuite_vxlan.py
> +++ b/tests/TestSuite_vxlan.py
> @@ -468,8 +468,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
> # verify detected l4 invalid checksum
> if "inner_l4_invalid" in kwargs:
> self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out)
> - == self.l4err_num + 1, "Failed to count inner l4 chksum error")
> - self.l4err_num += 1
> + == 1, "Failed to count inner l4 chksum error")
>
> # verify detected l3 invalid checksum
> if "ip_invalid" in kwargs:
> @@ -649,7 +648,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
> 'PORT': self.portMask}
> self.dut.send_expect(pmd_cmd, "testpmd>", 30)
> self.iperr_num = 0
> - self.l4err_num = 0
>
> # disable vlan filter
> self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
> @@ -724,7 +722,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
> 'PORT': self.portMask}
> self.dut.send_expect(pmd_cmd, "testpmd>", 30)
> self.iperr_num = 0
> - self.l4err_num = 0
>
> # disable vlan filter
> self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
> --
> 2.17.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-15 20:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-15 9:56 [dts] [PATCH V2] vxlan:Optimization check inner l4 invalid changqingxwu
2019-04-15 20:39 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).