* [dts] [PATCH V1] test/unit_test_eal: bind ports before verifying result
@ 2019-04-19 4:59 Wenjie Li
2019-04-19 5:03 ` Li, WenjieX A
2019-04-22 23:45 ` Tu, Lijuan
0 siblings, 2 replies; 3+ messages in thread
From: Wenjie Li @ 2019-04-19 4:59 UTC (permalink / raw)
To: dts; +Cc: Wenjie Li
Should bind the ports before verifying result; otherwise, if the case
failed, the ports are still unbound, it will affect the later tests.
Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
tests/TestSuite_unit_tests_eal.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
index 2249113..07d788f 100644
--- a/tests/TestSuite_unit_tests_eal.py
+++ b/tests/TestSuite_unit_tests_eal.py
@@ -321,8 +321,8 @@ class TestUnitTestsEal(TestCase):
# on FreeBSD need more time than other OS
out = self.dut.send_expect("eal_flags_autotest", "RTE>>", 600)
self.dut.send_expect("quit", "# ")
- self.verify("Test OK" in out, "Test failed")
self.dut.bind_interfaces_linux(driver=self.drivername)
+ self.verify("Test OK" in out, "Test failed")
def test_alarm(self):
"""
--
2.17.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dts] [PATCH V1] test/unit_test_eal: bind ports before verifying result
2019-04-19 4:59 [dts] [PATCH V1] test/unit_test_eal: bind ports before verifying result Wenjie Li
@ 2019-04-19 5:03 ` Li, WenjieX A
2019-04-22 23:45 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Li, WenjieX A @ 2019-04-19 5:03 UTC (permalink / raw)
To: dts; +Cc: Li, WenjieX A
Tested-by: Li, WenjieX A <wenjiex.a.li@intel.com>
> -----Original Message-----
> From: Li, WenjieX A
> Sent: Friday, April 19, 2019 1:00 PM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts][PATCH V1] test/unit_test_eal: bind ports before verifying result
>
> Should bind the ports before verifying result; otherwise, if the case failed, the
> ports are still unbound, it will affect the later tests.
>
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
> tests/TestSuite_unit_tests_eal.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
> index 2249113..07d788f 100644
> --- a/tests/TestSuite_unit_tests_eal.py
> +++ b/tests/TestSuite_unit_tests_eal.py
> @@ -321,8 +321,8 @@ class TestUnitTestsEal(TestCase):
> # on FreeBSD need more time than other OS
> out = self.dut.send_expect("eal_flags_autotest", "RTE>>", 600)
> self.dut.send_expect("quit", "# ")
> - self.verify("Test OK" in out, "Test failed")
> self.dut.bind_interfaces_linux(driver=self.drivername)
> + self.verify("Test OK" in out, "Test failed")
>
> def test_alarm(self):
> """
> --
> 2.17.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dts] [PATCH V1] test/unit_test_eal: bind ports before verifying result
2019-04-19 4:59 [dts] [PATCH V1] test/unit_test_eal: bind ports before verifying result Wenjie Li
2019-04-19 5:03 ` Li, WenjieX A
@ 2019-04-22 23:45 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-04-22 23:45 UTC (permalink / raw)
To: Li, WenjieX A, dts; +Cc: Li, WenjieX A
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Thursday, April 18, 2019 10:00 PM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] test/unit_test_eal: bind ports before verifying
> result
>
> Should bind the ports before verifying result; otherwise, if the case failed,
> the ports are still unbound, it will affect the later tests.
>
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
> tests/TestSuite_unit_tests_eal.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_unit_tests_eal.py
> b/tests/TestSuite_unit_tests_eal.py
> index 2249113..07d788f 100644
> --- a/tests/TestSuite_unit_tests_eal.py
> +++ b/tests/TestSuite_unit_tests_eal.py
> @@ -321,8 +321,8 @@ class TestUnitTestsEal(TestCase):
> # on FreeBSD need more time than other OS
> out = self.dut.send_expect("eal_flags_autotest", "RTE>>", 600)
> self.dut.send_expect("quit", "# ")
> - self.verify("Test OK" in out, "Test failed")
> self.dut.bind_interfaces_linux(driver=self.drivername)
> + self.verify("Test OK" in out, "Test failed")
>
> def test_alarm(self):
> """
> --
> 2.17.2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-22 23:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-19 4:59 [dts] [PATCH V1] test/unit_test_eal: bind ports before verifying result Wenjie Li
2019-04-19 5:03 ` Li, WenjieX A
2019-04-22 23:45 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).