test suite reviews and discussions
 help / color / mirror / Atom feed
From: Rami Rosen <ramirose@gmail.com>
To: dts@dpdk.org
Cc: Rami Rosen <ramirose@gmail.com>
Subject: [dts] [PATCH] tests/ipfrag: add method name in error message
Date: Mon, 22 Apr 2019 16:47:54 +0300	[thread overview]
Message-ID: <1555940874-143226-1-git-send-email-ramirose@gmail.com> (raw)

There is no way to know, when getting "failed on forward packet size"
error, whether it is from functional_check_ipv4() or functional_check_ipv6().
This patch adds the method name when in these two method so 
we will be able to track it.

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 tests/TestSuite_ipfrag.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_ipfrag.py b/tests/TestSuite_ipfrag.py
index 9f47a2c..38a27e9 100644
--- a/tests/TestSuite_ipfrag.py
+++ b/tests/TestSuite_ipfrag.py
@@ -170,7 +170,7 @@ l3fwd_ipv4_route_array[] = {\\\n"
 
             # verify normal packet just by number, verify fragment packet by all elements
             pkts = self.tester.load_tcpdump_sniff_packets(inst)
-            self.verify(len(pkts) == expPkts, "Failed on forward packet size " + str(size))
+            self.verify(len(pkts) == expPkts, "in functional_check_ipv4(): failed on forward packet size " + str(size))
             if flag == 'frag':
                 idx = 1
                 for pkt in pkts:
@@ -220,7 +220,7 @@ l3fwd_ipv4_route_array[] = {\\\n"
 
             # verify normal packet just by number, verify fragment packet by all elements
             pkts = self.tester.load_tcpdump_sniff_packets(inst)
-            self.verify(len(pkts) == expPkts, "Failed on forward packet size " + str(size))
+            self.verify(len(pkts) == expPkts, "In functional_check_ipv6(): failed on forward packet size " + str(size))
             if flag == 'frag':
                 idx = 1
                 for pkt in pkts:
-- 
1.8.3.1


             reply	other threads:[~2019-04-22 13:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-22 13:47 Rami Rosen [this message]
2019-04-23 20:34 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1555940874-143226-1-git-send-email-ramirose@gmail.com \
    --to=ramirose@gmail.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).