test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] framework/packet: remove the set of conf.use_pcap
@ 2019-06-03 22:22 lihong
  2019-06-05  5:21 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: lihong @ 2019-06-03 22:22 UTC (permalink / raw)
  To: dts; +Cc: lihong

when set scapy conf.use_pcap=True,
in scapy 2.2 and 2.3, it will affect the sniff and rdpcap method,
it will use the libpcap to read packet.
in scapy 2.4, it will affect the sendp method, it will use module
in pcapy, so you should upgrade pcapy to 0.11.3 if you want to set
the conf.use_pcap to True.
But after try, find it is not necessary to set the conf.use_pcap to
True, it no effect to our cases. so remove the config in the file,
that we no need to do anything after upgrade scapy.

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 framework/packet.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/framework/packet.py b/framework/packet.py
index 4d872fd..97344cd 100755
--- a/framework/packet.py
+++ b/framework/packet.py
@@ -45,7 +45,6 @@ from uuid import uuid4
 from settings import FOLDERS
 
 from scapy.config import conf
-conf.use_pcap = True
 
 import struct
 from socket import AF_INET6
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] framework/packet: remove the set of conf.use_pcap
  2019-06-03 22:22 [dts] [PATCH V1] framework/packet: remove the set of conf.use_pcap lihong
@ 2019-06-05  5:21 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-06-05  5:21 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Ma, LihongX



> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Tuesday, June 4, 2019 6:22 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] framework/packet: remove the set of
> conf.use_pcap
> 
> when set scapy conf.use_pcap=True,
> in scapy 2.2 and 2.3, it will affect the sniff and rdpcap method, it will use the
> libpcap to read packet.
> in scapy 2.4, it will affect the sendp method, it will use module in pcapy, so
> you should upgrade pcapy to 0.11.3 if you want to set the conf.use_pcap to
> True.
> But after try, find it is not necessary to set the conf.use_pcap to True, it no
> effect to our cases. so remove the config in the file, that we no need to do
> anything after upgrade scapy.
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  framework/packet.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/framework/packet.py b/framework/packet.py index
> 4d872fd..97344cd 100755
> --- a/framework/packet.py
> +++ b/framework/packet.py
> @@ -45,7 +45,6 @@ from uuid import uuid4  from settings import FOLDERS
> 
>  from scapy.config import conf
[Lijuan] I think this line should also be removed.
> -conf.use_pcap = True
> 
>  import struct
>  from socket import AF_INET6
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-05  5:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-03 22:22 [dts] [PATCH V1] framework/packet: remove the set of conf.use_pcap lihong
2019-06-05  5:21 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).