From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 90580A0096 for ; Thu, 6 Jun 2019 06:43:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E6961B959; Thu, 6 Jun 2019 06:43:36 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B69551B959 for ; Thu, 6 Jun 2019 06:43:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jun 2019 21:43:33 -0700 X-ExtLoop1: 1 Received: from ubuntu.sh.intel.com ([10.67.118.150]) by orsmga003.jf.intel.com with ESMTP; 05 Jun 2019 21:43:32 -0700 From: lihong To: dts@dpdk.org Cc: lihong Date: Thu, 6 Jun 2019 05:22:11 +0800 Message-Id: <1559769731-7704-1-git-send-email-lihongx.ma@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dts] [PATCH V2] framework/packet: remove the set of conf.use_pcap X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" when set scapy conf.use_pcap=True, in scapy 2.2 and 2.3, it will affect the sniff and rdpcap method, it will use the libpcap to read packet. in scapy 2.4, it will affect the sendp method, it will use module in pcapy, so you should upgrade pcapy to 0.11.3 if you want to set the conf.use_pcap to True. But after try, find it is not necessary to set the conf.use_pcap to True, it no effect to our cases. so remove the config in the file, that we no need to do anything after upgrade scapy. Signed-off-by: lihong --- framework/packet.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/framework/packet.py b/framework/packet.py index 4d872fd..e0b98e3 100755 --- a/framework/packet.py +++ b/framework/packet.py @@ -44,12 +44,8 @@ import shlex # separate command line for pipe from uuid import uuid4 from settings import FOLDERS -from scapy.config import conf -conf.use_pcap = True - import struct from socket import AF_INET6 -from scapy.all import conf from scapy.utils import wrpcap, rdpcap, hexstr from scapy.layers.inet import Ether, IP, TCP, UDP, ICMP from scapy.layers.inet6 import IPv6, IPv6ExtHdrRouting, IPv6ExtHdrFragment -- 2.7.4