[dts] [PATCH] tests/TestSuite_userspace_ethtool.py: Corrected error in userspaceethtool ringparam testcase.

[dts] [PATCH] tests/TestSuite_userspace_ethtool.py: Corrected error in userspaceethtool ringparam testcase.

[thaq]

From: Thanseerulhaq <thaq@marvell.com>

Observed ethtool ringparam setting command is passed worngly.
EthApp> ringparam <port_id> <tx_param> <rx_param>
        Set ring parameters

Signed-off-by: Thanseerulhaq <thaq@marvell.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 557a3ff..0a4b772 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -402,7 +402,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
             port = self.ports[index]
             ori_rx_pkts, ori_tx_pkts = self.strip_portstats(port)
             _, rx_max, _, tx_max = self.strip_ringparam(index)
-            self.dut.send_expect("ringparam %d %d %d" % (index, rx_max, tx_max), "EthApp>")
+            self.dut.send_expect("ringparam %d %d %d" % (index, tx_max, rx_max), "EthApp>")
             rx_ring, _, tx_ring, _ = self.strip_ringparam(index)
             self.verify(rx_ring == rx_max, "Userspace tool failed to set Rx ring parameter")
             self.verify(tx_ring == tx_max, "Userspace tool failed to set Tx ring parameter")
-- 
1.8.3.1

Re: [dts] [PATCH] tests/TestSuite_userspace_ethtool.py: Corrected error in userspaceethtool ringparam testcase.

[Tu, Lijuan]

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of thaq@marvell.com
> Sent: Wednesday, August 14, 2019 10:13 PM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; Thanseerulhaq
> <thaq@marvell.com>
> Subject: [dts] [PATCH] tests/TestSuite_userspace_ethtool.py: Corrected error
> in userspaceethtool ringparam testcase.
> 
> From: Thanseerulhaq <thaq@marvell.com>
> 
> Observed ethtool ringparam setting command is passed worngly.
> EthApp> ringparam <port_id> <tx_param> <rx_param>
>         Set ring parameters
> 
> Signed-off-by: Thanseerulhaq <thaq@marvell.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 557a3ff..0a4b772 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -402,7 +402,7 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>              port = self.ports[index]
>              ori_rx_pkts, ori_tx_pkts = self.strip_portstats(port)
>              _, rx_max, _, tx_max = self.strip_ringparam(index)
> -            self.dut.send_expect("ringparam %d %d %d" % (index, rx_max,
> tx_max), "EthApp>")
> +            self.dut.send_expect("ringparam %d %d %d" % (index, tx_max,
> rx_max), "EthApp>")
>              rx_ring, _, tx_ring, _ = self.strip_ringparam(index)
>              self.verify(rx_ring == rx_max, "Userspace tool failed to set Rx ring
> parameter")
>              self.verify(tx_ring == tx_max, "Userspace tool failed to set Tx ring
> parameter")
> --
> 1.8.3.1