From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1587A046B for ; Fri, 23 Aug 2019 10:09:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88E8E1BF86; Fri, 23 Aug 2019 10:09:46 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0ED7B1BF7E for ; Fri, 23 Aug 2019 10:09:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2019 01:09:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,420,1559545200"; d="scan'208";a="190874380" Received: from unknown (HELO dpdk-wenjielx-KVM193.icx.intel.com) ([10.240.176.193]) by orsmga002.jf.intel.com with ESMTP; 23 Aug 2019 01:09:43 -0700 From: Wenjie Li To: dts@dpdk.org Cc: Wenjie Li Date: Fri, 23 Aug 2019 17:03:23 +0000 Message-Id: <1566579803-48004-1-git-send-email-wenjiex.a.li@intel.com> X-Mailer: git-send-email 1.9.3 Subject: [dts] [PATCH V1] tests/tx_preparation: optimize script X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" move stop/quit testpmd into tear_down; otherwise, if one case is failed, the testpmd is still running, it will affect the following cases. Signed-off-by: Wenjie Li --- tests/TestSuite_tx_preparation.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/tests/TestSuite_tx_preparation.py b/tests/TestSuite_tx_preparation.py index eea95c1..ba0aac7 100644 --- a/tests/TestSuite_tx_preparation.py +++ b/tests/TestSuite_tx_preparation.py @@ -173,8 +173,6 @@ class TestTX_preparation(TestCase): self.dut_testpmd.execute_cmd('start') self.send_packet_verify() - self.dut_testpmd.execute_cmd('stop') - self.dut_testpmd.quit() def test_tx_preparation_TSO(self): """ @@ -185,16 +183,13 @@ class TestTX_preparation(TestCase): self.dut_testpmd.execute_cmd('start') self.send_packet_verify(1) - self.dut_testpmd.execute_cmd('stop') - self.dut_testpmd.quit() - def tear_down(self): """ Run after each test case. - """ - pass - + """ + self.dut_testpmd.execute_cmd('stop') + self.dut_testpmd.quit() def tear_down_all(self): """ -- 2.17.1