[dts] [PATCH V1]tests/pmd_stacked_bonded: set slave ports in right status

[dts] [PATCH V1]tests/pmd_stacked_bonded: set slave ports in right status

[yufengmx]

 quote Nicolau, Radu 
 port start all action is not really a defect, but due to a race condition this 
 setup implies; the right way will be to start top level bond port only, and let it 
 propagate the start to the bonded ports and they will propagate it to 
 the real nics. 

yufengmx (1):
  tests/pmd_stacked_bonded: set slave ports in right status

 tests/TestSuite_pmd_stacked_bonded.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
1.9.3

[dts] [PATCH V1]tests/pmd_stacked_bonded: set slave ports in right status

[yufengmx]

port start all action implies the race condition. The right way is to start
top level bond port only, and let it propagate the start action to slave bonded ports
and its the real nics.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_pmd_stacked_bonded.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_pmd_stacked_bonded.py b/tests/TestSuite_pmd_stacked_bonded.py
index e1ce01a..de126b9 100644
--- a/tests/TestSuite_pmd_stacked_bonded.py
+++ b/tests/TestSuite_pmd_stacked_bonded.py
@@ -138,7 +138,10 @@ class TestBondingStacked(TestCase):
         cmds = [
             ["port stop all", ''],
             ["set portlist " + ",".join([str(port) for port in portList]), ''],
-            ["port start all", ' ', 15]]
+            # start top level bond port only, and let it propagate the start
+            # action to slave bond ports and its the real nics.
+            ["port start {}".format(master_bond_port), ' ', 15]
+        ]
         self.bond_inst.d_console(cmds)
         # blank space command is used to skip LSC event to avoid core dumped issue
         time.sleep(5)
-- 
1.9.3

Re: [dts] [PATCH V1]tests/pmd_stacked_bonded: set slave ports in right status

[Wu, ChangqingX]

Tested-by: Wu, ChangqingX <changqingx.wu@intel.com>

-----Original Message-----
From: Mo, YufengX 
Sent: Monday, August 26, 2019 1:31 PM
To: Wu, ChangqingX <changqingx.wu@intel.com>; dts@dpdk.org
Cc: Mo, YufengX <yufengx.mo@intel.com>
Subject: [dts][PATCH V1]tests/pmd_stacked_bonded: set slave ports in right status


port start all action implies the race condition. The right way is to start top level bond port only, and let it propagate the start action to slave bonded ports and its the real nics.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_pmd_stacked_bonded.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_pmd_stacked_bonded.py b/tests/TestSuite_pmd_stacked_bonded.py
index e1ce01a..de126b9 100644
--- a/tests/TestSuite_pmd_stacked_bonded.py
+++ b/tests/TestSuite_pmd_stacked_bonded.py
@@ -138,7 +138,10 @@ class TestBondingStacked(TestCase):
         cmds = [
             ["port stop all", ''],
             ["set portlist " + ",".join([str(port) for port in portList]), ''],
-            ["port start all", ' ', 15]]
+            # start top level bond port only, and let it propagate the start
+            # action to slave bond ports and its the real nics.
+            ["port start {}".format(master_bond_port), ' ', 15]
+        ]
         self.bond_inst.d_console(cmds)
         # blank space command is used to skip LSC event to avoid core dumped issue
         time.sleep(5)
--
1.9.3

Re: [dts] [PATCH V1]tests/pmd_stacked_bonded: set slave ports in right status

[Tu, Lijuan]

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: Monday, August 26, 2019 1:31 PM
> To: Wu, ChangqingX <changqingx.wu@intel.com>; dts@dpdk.org
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V1]tests/pmd_stacked_bonded: set slave ports in right
> status
> 
> 
> port start all action implies the race condition. The right way is to start top
> level bond port only, and let it propagate the start action to slave bonded
> ports and its the real nics.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  tests/TestSuite_pmd_stacked_bonded.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_pmd_stacked_bonded.py
> b/tests/TestSuite_pmd_stacked_bonded.py
> index e1ce01a..de126b9 100644
> --- a/tests/TestSuite_pmd_stacked_bonded.py
> +++ b/tests/TestSuite_pmd_stacked_bonded.py
> @@ -138,7 +138,10 @@ class TestBondingStacked(TestCase):
>          cmds = [
>              ["port stop all", ''],
>              ["set portlist " + ",".join([str(port) for port in portList]), ''],
> -            ["port start all", ' ', 15]]
> +            # start top level bond port only, and let it propagate the start
> +            # action to slave bond ports and its the real nics.
> +            ["port start {}".format(master_bond_port), ' ', 15]
> +        ]
>          self.bond_inst.d_console(cmds)
>          # blank space command is used to skip LSC event to avoid core dumped
> issue
>          time.sleep(5)
> --
> 1.9.3