test suite reviews and discussions
 help / color / mirror / Atom feed
From: <pvukkisala@marvell.com>
To: <dts@dpdk.org>
Cc: <avijay@marvell.com>, <fmasood@marvell.com>,
	Phanendra Vukkisala <pvukkisala@marvell.com>
Subject: [dts] [PATCH] ptpclient: don't use software time stamping for cavm devices
Date: Sat, 19 Oct 2019 21:23:28 +0530	[thread overview]
Message-ID: <1571500408-29095-1-git-send-email-pvukkisala@marvell.com> (raw)

From: Phanendra Vukkisala <pvukkisala@marvell.com>

Aslo fix random failure occurs due to timing
Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
---
 tests/TestSuite_ptpclient.py |   14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_ptpclient.py b/tests/TestSuite_ptpclient.py
index 23590e4..461abf1 100644
--- a/tests/TestSuite_ptpclient.py
+++ b/tests/TestSuite_ptpclient.py
@@ -98,7 +98,10 @@ class TestPtpClient(TestCase):
         ptp client test case.
         """
         # use the first port on that self.nic
-        self.tester.send_expect("ptp4l -i %s -2 -m -S &" % self.itf0, "ptp4l")
+        if self.nic in ["cavium_a063", "cavium_a064"]:
+            self.tester.send_expect("ptp4l -i %s -2 -m &" % self.itf0, "ptp4l")
+        else:
+            self.tester.send_expect("ptp4l -i %s -2 -m -S &" % self.itf0, "ptp4l")
 
         # run ptpclient on the background
         self.dut.send_expect("./examples/ptpclient/build/ptpclient -c f -n 3 -- -T 0 -p 0x1 " + "&", "Delta between master and slave", 60)
@@ -125,7 +128,10 @@ class TestPtpClient(TestCase):
         d_time = self.dut.send_expect("date '+%Y-%m-%d %H:%M'","# ")
         self.verify(d_time == '2000-01-01 00:00', "set the time error")
 
-        self.tester.send_expect("ptp4l -i %s -2 -m -S &" % self.itf0, "ptp4l")
+        if self.nic in ["cavium_a063", "cavium_a064"]:
+            self.tester.send_expect("ptp4l -i %s -2 -m &" % self.itf0, "ptp4l")
+        else:
+            self.tester.send_expect("ptp4l -i %s -2 -m -S &" % self.itf0, "ptp4l")
 
         # run ptpclient on the background
         self.dut.send_expect("./examples/ptpclient/build/ptpclient -c f -n 3 -- -T 1 -p 0x1" + "&", "Delta between master and slave", 60)
@@ -152,6 +158,10 @@ class TestPtpClient(TestCase):
         # the output will include kill process info, at that time need get system time again.
         if len(dut_out) != len(tester_out):
             dut_out = self.dut.send_expect("date -u '+%Y-%m-%d %H:%M'", "# ")
+        ## In rare cases minute may change while getting time. So get time again
+        if dut_out != tester_out:
+            tester_out = self.tester.send_expect("date -u '+%Y-%m-%d %H:%M'", "# ")
+            dut_out = self.dut.send_expect("date -u '+%Y-%m-%d %H:%M'", "# ")
 
         self.verify(tester_out == dut_out, "the DUT time synchronous error")
 
-- 
1.7.9.5


             reply	other threads:[~2019-10-19 15:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-19 15:53 pvukkisala [this message]
2019-10-23  9:51 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1571500408-29095-1-git-send-email-pvukkisala@marvell.com \
    --to=pvukkisala@marvell.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).