test suite reviews and discussions
 help / color / mirror / Atom feed
From: <nareddy@marvell.com>
To: <dts@dpdk.org>
Cc: <fmasood@marvell.com>, <avijay@marvell.com>,
	<pvukkisala@marvell.com>, Praneeth Reddy <nareddy@marvell.com>
Subject: [dts] [PATCH] TestSuite_rss_to_rte_flow.py: Adding priority to rules to avoid overlapping in cavium_a063
Date: Thu, 31 Oct 2019 11:52:20 +0530	[thread overview]
Message-ID: <1572502940-3645-1-git-send-email-nareddy@marvell.com> (raw)

From: Praneeth Reddy <nareddy@marvell.com>

According to RTE FLow spec, if we add the overlapping rules with same priority, behavior is unknown
So added priority for each rule

Signed-off-by: Praneeth Reddy <nareddy@marvell.com>
---
 tests/TestSuite_rss_to_rte_flow.py | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_rss_to_rte_flow.py b/tests/TestSuite_rss_to_rte_flow.py
index 1198c3e..e745e14 100644
--- a/tests/TestSuite_rss_to_rte_flow.py
+++ b/tests/TestSuite_rss_to_rte_flow.py
@@ -538,8 +538,12 @@ class TestRSS_to_Rteflow(TestCase):
         time.sleep(2)
 
         # Create a rss queue rule
-        self.dut.send_expect(
-            "flow create 0 ingress pattern end actions rss types udp end queues 3 4 5 end / end", "created")
+        if (self.nic in ["cavium_a063", "cavium_a064"]):
+            self.dut.send_expect(
+                "flow create 0 ingress priority 2 pattern end actions rss types udp end queues 3 4 5 end / end", "created")
+        else:
+            self.dut.send_expect(
+                "flow create 0 ingress pattern end actions rss types udp end queues 3 4 5 end / end", "created")
         # send the packets and verify the results
         rss_queue = ["3", "4", "5"]
         self.send_and_check(self.pkt2, rss_queue)
@@ -551,6 +555,10 @@ class TestRSS_to_Rteflow(TestCase):
             rss_queue = ["1"]
             pkt = "Ether(dst='%s')/IP(src='10.0.0.1',dst='192.168.0.2',proto=6)/UDP(dport=50, sport=50)/('X'*48)" % self.pf_mac
             self.send_and_check(pkt, rss_queue)
+        elif (self.nic in ["cavium_a063", "cavium_a064"]):
+            # Create a flow director rule
+            self.dut.send_expect(
+                "flow create 0 ingress priority 1 pattern eth / ipv4 src is 10.0.0.1 dst is 192.168.0.2 / udp src is 50 dst is 50 / end actions queue index 1 / end", "created")
         else:
             # Create a flow director rule
             self.dut.send_expect(
-- 
1.8.3.1


                 reply	other threads:[~2019-10-31  6:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1572502940-3645-1-git-send-email-nareddy@marvell.com \
    --to=nareddy@marvell.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    --cc=pvukkisala@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).