test suite reviews and discussions
 help / color / mirror / Atom feed
From: Wenjie Li <wenjiex.a.li@intel.com>
To: dts@dpdk.org
Cc: Wenjie Li <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL
Date: Thu, 28 Nov 2019 15:22:27 +0000	[thread overview]
Message-ID: <1574954547-24055-1-git-send-email-wenjiex.a.li@intel.com> (raw)

In DPDK fdcf92ed6637b790, the 'port stop' will recovery the oringnal link 
status for CVL. 
If the link is up, it should be up after 'port stop'; if down, then be down.
This is different with other NICs.

In test case stop_restart, the port is up before 'port stop', so verify
the port is UP for CVL and down for other NICs.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_shutdown_api.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 63fff84..58daad1 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -201,7 +201,10 @@ class TestShutdownApi(TestCase):
         self.check_forwarding(received=False)
         self.dut.send_expect("port stop all", "testpmd> ", 100)
         time.sleep(5)
-        self.check_ports(status=False)
+        if self.nic in ["columbiaville_25g", "columbiaville_100g"]:
+            self.check_ports(status=True)
+        else:
+            self.check_ports(status=False)
         self.dut.send_expect("port start all", "testpmd> ", 100)
         time.sleep(5)
         self.check_ports(status=True)
-- 
2.17.1


             reply	other threads:[~2019-11-28  6:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28 15:22 Wenjie Li [this message]
2019-11-28  6:38 ` Zhu, WenhuiX
2019-12-02  6:31   ` Ma, LihongX
2019-12-04  5:36 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1574954547-24055-1-git-send-email-wenjiex.a.li@intel.com \
    --to=wenjiex.a.li@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).