Re: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL

Re: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL

[Zhu, WenhuiX]

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]


Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
Sent: Thursday, November 28, 2019 11:22 PM
To: dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL

In DPDK fdcf92ed6637b790, the 'port stop' will recovery the oringnal link status for CVL. 
If the link is up, it should be up after 'port stop'; if down, then be down.
This is different with other NICs.

In test case stop_restart, the port is up before 'port stop', so verify the port is UP for CVL and down for other NICs.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_shutdown_api.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index 63fff84..58daad1 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -201,7 +201,10 @@ class TestShutdownApi(TestCase):
         self.check_forwarding(received=False)
         self.dut.send_expect("port stop all", "testpmd> ", 100)
         time.sleep(5)
-        self.check_ports(status=False)
+        if self.nic in ["columbiaville_25g", "columbiaville_100g"]:
+            self.check_ports(status=True)
+        else:
+            self.check_ports(status=False)
         self.dut.send_expect("port start all", "testpmd> ", 100)
         time.sleep(5)
         self.check_ports(status=True)
--
2.17.1


[-- Attachment #2: TestShutdownApi.log --]
[-- Type: application/octet-stream, Size: 648789 bytes --]

[dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL

[Wenjie Li]

In DPDK fdcf92ed6637b790, the 'port stop' will recovery the oringnal link 
status for CVL. 
If the link is up, it should be up after 'port stop'; if down, then be down.
This is different with other NICs.

In test case stop_restart, the port is up before 'port stop', so verify
the port is UP for CVL and down for other NICs.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_shutdown_api.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 63fff84..58daad1 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -201,7 +201,10 @@ class TestShutdownApi(TestCase):
         self.check_forwarding(received=False)
         self.dut.send_expect("port stop all", "testpmd> ", 100)
         time.sleep(5)
-        self.check_ports(status=False)
+        if self.nic in ["columbiaville_25g", "columbiaville_100g"]:
+            self.check_ports(status=True)
+        else:
+            self.check_ports(status=False)
         self.dut.send_expect("port start all", "testpmd> ", 100)
         time.sleep(5)
         self.check_ports(status=True)
-- 
2.17.1

Re: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL

[Ma, LihongX]

Reviewed-by: ma,lihong<lihongx.ma@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhu, WenhuiX
Sent: Thursday, November 28, 2019 2:39 PM
To: Li, WenjieX A <wenjiex.a.li@intel.com>; dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: Re: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL


Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
Sent: Thursday, November 28, 2019 11:22 PM
To: dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL

In DPDK fdcf92ed6637b790, the 'port stop' will recovery the oringnal link status for CVL. 
If the link is up, it should be up after 'port stop'; if down, then be down.
This is different with other NICs.

In test case stop_restart, the port is up before 'port stop', so verify the port is UP for CVL and down for other NICs.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_shutdown_api.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index 63fff84..58daad1 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -201,7 +201,10 @@ class TestShutdownApi(TestCase):
         self.check_forwarding(received=False)
         self.dut.send_expect("port stop all", "testpmd> ", 100)
         time.sleep(5)
-        self.check_ports(status=False)
+        if self.nic in ["columbiaville_25g", "columbiaville_100g"]:
+            self.check_ports(status=True)
+        else:
+            self.check_ports(status=False)
         self.dut.send_expect("port start all", "testpmd> ", 100)
         time.sleep(5)
         self.check_ports(status=True)
--
2.17.1

Re: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL

[Tu, Lijuan]

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Thursday, November 28, 2019 11:22 PM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal
> link status for CVL
> 
> In DPDK fdcf92ed6637b790, the 'port stop' will recovery the oringnal link
> status for CVL.
> If the link is up, it should be up after 'port stop'; if down, then be down.
> This is different with other NICs.
> 
> In test case stop_restart, the port is up before 'port stop', so verify the port is
> UP for CVL and down for other NICs.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_shutdown_api.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 63fff84..58daad1 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -201,7 +201,10 @@ class TestShutdownApi(TestCase):
>          self.check_forwarding(received=False)
>          self.dut.send_expect("port stop all", "testpmd> ", 100)
>          time.sleep(5)
> -        self.check_ports(status=False)
> +        if self.nic in ["columbiaville_25g", "columbiaville_100g"]:
> +            self.check_ports(status=True)
> +        else:
> +            self.check_ports(status=False)
>          self.dut.send_expect("port start all", "testpmd> ", 100)
>          time.sleep(5)
>          self.check_ports(status=True)
> --
> 2.17.1