test suite reviews and discussions
 help / color / mirror / Atom feed
From: Zeng Xiaoxiao <xiaoxiaox.zeng@intel.com>
To: dts@dpdk.org
Cc: Zeng Xiaoxiao <xiaoxiaox.zeng@intel.com>
Subject: [dts]  [PATCH V2] tests/port_control:add if else to suit cvl
Date: Thu,  9 Jan 2020 10:48:38 +0800	[thread overview]
Message-ID: <1578538118-234221-1-git-send-email-xiaoxiaox.zeng@intel.com> (raw)

Signed-off-by: Zeng Xiaoxiao <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_port_control.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py
index a458add..f006ddb 100644
--- a/tests/TestSuite_port_control.py
+++ b/tests/TestSuite_port_control.py
@@ -166,12 +166,18 @@ class TestPortControl(TestCase):
         terminal.execute_cmd("stop")
         terminal.execute_cmd("port stop all")
         ret = terminal.get_port_link_status(self.port_id_0)
-        self.verify(ret == "down", "port not down!")
+        if self.nic.startswith('columbiaville'):
+            self.verify(ret != "", "port status error!")
+        else:
+            self.verify(ret == "down", "port not down!")
 
     def reset_pmd_port(self, terminal):
         terminal.execute_cmd("port reset all")
         ret = terminal.get_port_link_status(self.port_id_0)
-        self.verify(ret == "down", "port reset fail!")
+        if self.nic.startswith('columbiaville'):
+            self.verify(ret != "", "port status error!")
+        else:
+            self.verify(ret == "down", "port not down!")
 
     def close_pmd_port(self, terminal):
         terminal.execute_cmd("port close all")
-- 
1.8.3.1


             reply	other threads:[~2020-01-09  2:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09  2:48 Zeng Xiaoxiao [this message]
2020-01-09  3:05 ` Zhu, WenhuiX
2020-01-09  8:34 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1578538118-234221-1-git-send-email-xiaoxiaox.zeng@intel.com \
    --to=xiaoxiaox.zeng@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).