test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1]tests/pvp_multi_paths_performance: optimize eal parameters
@ 2020-01-23  5:43 Xiao Qimai
  2020-02-10  9:05 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Xiao Qimai @ 2020-01-23  5:43 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

optimize eal parameters

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_pvp_multi_paths_performance.py | 29 +++++++++++---------------
 1 file changed, 12 insertions(+), 17 deletions(-)

diff --git a/tests/TestSuite_pvp_multi_paths_performance.py b/tests/TestSuite_pvp_multi_paths_performance.py
index 4c91ebe..df24e77 100644
--- a/tests/TestSuite_pvp_multi_paths_performance.py
+++ b/tests/TestSuite_pvp_multi_paths_performance.py
@@ -58,10 +58,6 @@ class TestPVPMultiPathPerformance(TestCase):
         self.core_list_host = self.core_list[2:4]
         self.core_mask_user = utils.create_mask(self.core_list_user)
         self.core_mask_host = utils.create_mask(self.core_list_host)
-        if len(set([int(core['socket']) for core in self.dut.cores])) == 1:
-            self.socket_mem = '1024'
-        else:
-            self.socket_mem = '1024,1024'
 
         self.out_path = '/tmp'
         out = self.tester.send_expect('ls -d %s' % self.out_path, '# ')
@@ -127,12 +123,11 @@ class TestPVPMultiPathPerformance(TestCase):
         self.dut.send_expect("rm -rf ./vhost-net*", "#")
         self.dut.send_expect("killall -s INT testpmd", "#")
         self.dut.send_expect("killall -s INT qemu-system-x86_64", "#")
-        command_line_client = "./%s/app/testpmd -n %d -c %s --socket-mem " + \
-                              " %s --legacy-mem -w %s --file-prefix=vhost --vdev " + \
-                              "'net_vhost0,iface=vhost-net,queues=1,client=0' -- -i --nb-cores=1 --txd=1024 --rxd=1024"
-        command_line_client = command_line_client % (self.target,
-            self.dut.get_memory_channels(), self.core_mask_host,
-            self.socket_mem, self.dut.ports_info[self.dut_ports[0]]['pci'])
+        eal_param = self.dut.create_eal_parameters(socket=self.ports_socket, prefix='vhost',
+                                                   ports=[self.dut.ports_info[self.dut_ports[0]]['pci']],
+                                                   vdevs=['net_vhost0,iface=vhost-net,queues=1,client=0'])
+        eal_param += " --single-file-segments"
+        command_line_client = "./%s/app/testpmd " % self.target + eal_param + " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
         self.vhost.send_expect(command_line_client, "testpmd> ", 120)
         self.vhost.send_expect("set fwd mac", "testpmd> ", 120)
         self.vhost.send_expect("start", "testpmd> ", 120)
@@ -141,13 +136,13 @@ class TestPVPMultiPathPerformance(TestCase):
         """
         start testpmd on virtio
         """
-        command_line_user = "./%s/app/testpmd -n %d -c %s " + \
-                            " --socket-mem %s --legacy-mem --no-pci --file-prefix=virtio " + \
-                            "--vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,%s " + \
-                            "-- -i %s --rss-ip --nb-cores=1 --txd=1024 --rxd=1024"
-        command_line_user = command_line_user % (self.target,
-            self.dut.get_memory_channels(), self.core_mask_user,
-            self.socket_mem, args["version"], args["path"])
+        eal_param = self.dut.create_eal_parameters(socket=self.ports_socket, prefix='virtio',
+                                                   no_pci=True,
+                                                   vdevs=['net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,%s' %
+                                                          args["version"]])
+        eal_param += " --single-file-segments"
+        command_line_user = "./%s/app/testpmd " % self.target + eal_param + " -- -i %s --rss-ip --nb-cores=1 --txd=1024 --rxd=1024" % \
+                            args["path"]
         self.vhost_user = self.dut.new_session(suite="user")
         self.vhost_user.send_expect(command_line_user, "testpmd> ", 120)
         self.vhost_user.send_expect("set fwd mac", "testpmd> ", 120)
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1]tests/pvp_multi_paths_performance: optimize eal parameters
  2020-01-23  5:43 [dts] [PATCH V1]tests/pvp_multi_paths_performance: optimize eal parameters Xiao Qimai
@ 2020-02-10  9:05 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2020-02-10  9:05 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Thursday, January 23, 2020 1:44 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]tests/pvp_multi_paths_performance: optimize eal
> parameters
> 
> optimize eal parameters
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_pvp_multi_paths_performance.py | 29 +++++++++++----------
> -----
>  1 file changed, 12 insertions(+), 17 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_multi_paths_performance.py
> b/tests/TestSuite_pvp_multi_paths_performance.py
> index 4c91ebe..df24e77 100644
> --- a/tests/TestSuite_pvp_multi_paths_performance.py
> +++ b/tests/TestSuite_pvp_multi_paths_performance.py
> @@ -58,10 +58,6 @@ class TestPVPMultiPathPerformance(TestCase):
>          self.core_list_host = self.core_list[2:4]
>          self.core_mask_user = utils.create_mask(self.core_list_user)
>          self.core_mask_host = utils.create_mask(self.core_list_host)
> -        if len(set([int(core['socket']) for core in self.dut.cores])) == 1:
> -            self.socket_mem = '1024'
> -        else:
> -            self.socket_mem = '1024,1024'
> 
>          self.out_path = '/tmp'
>          out = self.tester.send_expect('ls -d %s' % self.out_path, '# ') @@ -127,12
> +123,11 @@ class TestPVPMultiPathPerformance(TestCase):
>          self.dut.send_expect("rm -rf ./vhost-net*", "#")
>          self.dut.send_expect("killall -s INT testpmd", "#")
>          self.dut.send_expect("killall -s INT qemu-system-x86_64", "#")
> -        command_line_client = "./%s/app/testpmd -n %d -c %s --socket-mem "
> + \
> -                              " %s --legacy-mem -w %s --file-prefix=vhost --vdev " + \
> -                              "'net_vhost0,iface=vhost-net,queues=1,client=0' -- -i --nb-
> cores=1 --txd=1024 --rxd=1024"
> -        command_line_client = command_line_client % (self.target,
> -            self.dut.get_memory_channels(), self.core_mask_host,
> -            self.socket_mem, self.dut.ports_info[self.dut_ports[0]]['pci'])
> +        eal_param = self.dut.create_eal_parameters(socket=self.ports_socket,
> prefix='vhost',
> +
> ports=[self.dut.ports_info[self.dut_ports[0]]['pci']],
> +                                                   vdevs=['net_vhost0,iface=vhost-
> net,queues=1,client=0'])
> +        eal_param += " --single-file-segments"
> +        command_line_client = "./%s/app/testpmd " % self.target + eal_param
> + " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
>          self.vhost.send_expect(command_line_client, "testpmd> ", 120)
>          self.vhost.send_expect("set fwd mac", "testpmd> ", 120)
>          self.vhost.send_expect("start", "testpmd> ", 120) @@ -141,13 +136,13
> @@ class TestPVPMultiPathPerformance(TestCase):
>          """
>          start testpmd on virtio
>          """
> -        command_line_user = "./%s/app/testpmd -n %d -c %s " + \
> -                            " --socket-mem %s --legacy-mem --no-pci --file-prefix=virtio "
> + \
> -                            "--
> vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,%s " + \
> -                            "-- -i %s --rss-ip --nb-cores=1 --txd=1024 --rxd=1024"
> -        command_line_user = command_line_user % (self.target,
> -            self.dut.get_memory_channels(), self.core_mask_user,
> -            self.socket_mem, args["version"], args["path"])
> +        eal_param = self.dut.create_eal_parameters(socket=self.ports_socket,
> prefix='virtio',
> +                                                   no_pci=True,
> +
> vdevs=['net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,%s' %
> +                                                          args["version"]])
> +        eal_param += " --single-file-segments"
> +        command_line_user = "./%s/app/testpmd " % self.target + eal_param +
> " -- -i %s --rss-ip --nb-cores=1 --txd=1024 --rxd=1024" % \
> +                            args["path"]
>          self.vhost_user = self.dut.new_session(suite="user")
>          self.vhost_user.send_expect(command_line_user, "testpmd> ", 120)
>          self.vhost_user.send_expect("set fwd mac", "testpmd> ", 120)
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-10  9:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-23  5:43 [dts] [PATCH V1]tests/pvp_multi_paths_performance: optimize eal parameters Xiao Qimai
2020-02-10  9:05 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).