test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1]shutdown_api: fix scapy cmd error
@ 2020-04-17  8:48 Xiao Qimai
  2020-04-20  5:24 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Xiao Qimai @ 2020-04-17  8:48 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

*. mac addr should be enclosed in quotation marks

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_shutdown_api.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 8661863..b5c0d5a 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -709,7 +709,7 @@ class TestShutdownApi(TestCase):
         tgenInput = []
         for port in self.ports:
             dmac=self.dut.get_mac_address(port)
-            self.tester.scapy_append('wrpcap("test%d.pcap",[Ether(src="02:00:00:00:00:0%d",dst=%s)/IP()/UDP()/()])'% (port, port, dmac))
+            self.tester.scapy_append('wrpcap("test%d.pcap",[Ether(src="02:00:00:00:00:0%d",dst="%s")/IP()/UDP()/()])'% (port, port, dmac))
             tgenInput.append((self.tester.get_local_port(port), self.tester.get_local_port(port), "test%d.pcap" % port))
         for _ in range(stress_iterations):
             self.dut.send_expect("port stop all", "testpmd> ", 100)
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1]shutdown_api: fix scapy cmd error
  2020-04-17  8:48 [dts] [PATCH V1]shutdown_api: fix scapy cmd error Xiao Qimai
@ 2020-04-20  5:24 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2020-04-20  5:24 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Friday, April 17, 2020 4:49 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]shutdown_api: fix scapy cmd error
> 
> *. mac addr should be enclosed in quotation marks
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_shutdown_api.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 8661863..b5c0d5a 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -709,7 +709,7 @@ class TestShutdownApi(TestCase):
>          tgenInput = []
>          for port in self.ports:
>              dmac=self.dut.get_mac_address(port)
> -
> self.tester.scapy_append('wrpcap("test%d.pcap",[Ether(src="02:00:00:00:00:
> 0%d",dst=%s)/IP()/UDP()/()])'% (port, port, dmac))
> +
> + self.tester.scapy_append('wrpcap("test%d.pcap",[Ether(src="02:00:00:00
> + :00:0%d",dst="%s")/IP()/UDP()/()])'% (port, port, dmac))
>              tgenInput.append((self.tester.get_local_port(port),
> self.tester.get_local_port(port), "test%d.pcap" % port))
>          for _ in range(stress_iterations):
>              self.dut.send_expect("port stop all", "testpmd> ", 100)
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-20  5:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17  8:48 [dts] [PATCH V1]shutdown_api: fix scapy cmd error Xiao Qimai
2020-04-20  5:24 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).