From: xizhan4x <xix.zhang@intel.com>
To: dts@dpdk.org
Cc: xizhan4x <xix.zhang@intel.com>
Subject: [dts] [PATCH V1] tests/TestSuite_shutdown_api:Modify the execution order of shutting down the VM environment
Date: Fri, 3 Jul 2020 11:07:39 +0800 [thread overview]
Message-ID: <1593745659-29077-1-git-send-email-xix.zhang@intel.com> (raw)
Modify the execution order of shutting down the VM environment,
The correct step should be to shut down the VM environment before unbind Vf
Signed-off-by: xizhan4x <xix.zhang@intel.com>
---
tests/TestSuite_shutdown_api.py | 23 +++++++++++++----------
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 650ccfc..9fc3e3a 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -296,6 +296,16 @@ class TestShutdownApi(TestCase):
def destroy_vm_env(self):
+ if getattr(self, 'self.vm0_testpmd', None):
+ self.vm0_testpmd.quit()
+
+ if getattr(self, 'vm0', None):
+ if getattr(self, 'vm0_dut', None):
+ self.vm0_dut.kill_all()
+ self.vm0_testpmd = None
+ self.vm0_dut_ports = None
+ # destroy vm0
+ self.vm0.stop()
if getattr(self, 'used_dut_port', None) is not None:
self.dut.destroy_sriov_vfs_by_port(self.used_dut_port)
self.used_dut_port = None
@@ -308,18 +318,11 @@ class TestShutdownApi(TestCase):
if not self.vm_env_done:
return
- if getattr(self, 'self.vm0_testpmd', None):
- self.vm0_testpmd.quit()
-
- if getattr(self, 'vm0', None):
- if getattr(self, 'vm0_dut', None):
- self.vm0_dut.kill_all()
- self.vm0_testpmd = None
- self.vm0_dut_ports = None
- # destroy vm0
- self.vm0.stop()
self.vm_env_done = False
+
+
+
def test_stop_restart(self):
"""
Stop and Restar.
--
1.8.3.1
next reply other threads:[~2020-07-03 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 3:07 xizhan4x [this message]
2020-07-03 3:10 ` Zhang, XiX
2020-07-20 6:55 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1593745659-29077-1-git-send-email-xix.zhang@intel.com \
--to=xix.zhang@intel.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).