* [dts] [PATCH V1] tests/TestSuite_shutdown_api:Modify the execution order of shutting down the VM environment
@ 2020-07-03 3:07 xizhan4x
2020-07-03 3:10 ` Zhang, XiX
2020-07-20 6:55 ` Tu, Lijuan
0 siblings, 2 replies; 3+ messages in thread
From: xizhan4x @ 2020-07-03 3:07 UTC (permalink / raw)
To: dts; +Cc: xizhan4x
Modify the execution order of shutting down the VM environment,
The correct step should be to shut down the VM environment before unbind Vf
Signed-off-by: xizhan4x <xix.zhang@intel.com>
---
tests/TestSuite_shutdown_api.py | 23 +++++++++++++----------
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 650ccfc..9fc3e3a 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -296,6 +296,16 @@ class TestShutdownApi(TestCase):
def destroy_vm_env(self):
+ if getattr(self, 'self.vm0_testpmd', None):
+ self.vm0_testpmd.quit()
+
+ if getattr(self, 'vm0', None):
+ if getattr(self, 'vm0_dut', None):
+ self.vm0_dut.kill_all()
+ self.vm0_testpmd = None
+ self.vm0_dut_ports = None
+ # destroy vm0
+ self.vm0.stop()
if getattr(self, 'used_dut_port', None) is not None:
self.dut.destroy_sriov_vfs_by_port(self.used_dut_port)
self.used_dut_port = None
@@ -308,18 +318,11 @@ class TestShutdownApi(TestCase):
if not self.vm_env_done:
return
- if getattr(self, 'self.vm0_testpmd', None):
- self.vm0_testpmd.quit()
-
- if getattr(self, 'vm0', None):
- if getattr(self, 'vm0_dut', None):
- self.vm0_dut.kill_all()
- self.vm0_testpmd = None
- self.vm0_dut_ports = None
- # destroy vm0
- self.vm0.stop()
self.vm_env_done = False
+
+
+
def test_stop_restart(self):
"""
Stop and Restar.
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1] tests/TestSuite_shutdown_api:Modify the execution order of shutting down the VM environment
2020-07-03 3:07 [dts] [PATCH V1] tests/TestSuite_shutdown_api:Modify the execution order of shutting down the VM environment xizhan4x
@ 2020-07-03 3:10 ` Zhang, XiX
2020-07-20 6:55 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Zhang, XiX @ 2020-07-03 3:10 UTC (permalink / raw)
To: dts
[-- Attachment #1: Type: text/plain, Size: 2051 bytes --]
Tested-by: xizhan4x <xix.zhang@intel.com>
-----Original Message-----
From: Zhang, XiX
Sent: Friday, July 3, 2020 11:08 AM
To: dts@dpdk.org
Cc: Zhang, XiX <xix.zhang@intel.com>
Subject: [dts][PATCH V1] tests/TestSuite_shutdown_api:Modify the execution order of shutting down the VM environment
Modify the execution order of shutting down the VM environment, The correct step should be to shut down the VM environment before unbind Vf
Signed-off-by: xizhan4x <xix.zhang@intel.com>
---
tests/TestSuite_shutdown_api.py | 23 +++++++++++++----------
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index 650ccfc..9fc3e3a 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -296,6 +296,16 @@ class TestShutdownApi(TestCase):
def destroy_vm_env(self):
+ if getattr(self, 'self.vm0_testpmd', None):
+ self.vm0_testpmd.quit()
+
+ if getattr(self, 'vm0', None):
+ if getattr(self, 'vm0_dut', None):
+ self.vm0_dut.kill_all()
+ self.vm0_testpmd = None
+ self.vm0_dut_ports = None
+ # destroy vm0
+ self.vm0.stop()
if getattr(self, 'used_dut_port', None) is not None:
self.dut.destroy_sriov_vfs_by_port(self.used_dut_port)
self.used_dut_port = None
@@ -308,18 +318,11 @@ class TestShutdownApi(TestCase):
if not self.vm_env_done:
return
- if getattr(self, 'self.vm0_testpmd', None):
- self.vm0_testpmd.quit()
-
- if getattr(self, 'vm0', None):
- if getattr(self, 'vm0_dut', None):
- self.vm0_dut.kill_all()
- self.vm0_testpmd = None
- self.vm0_dut_ports = None
- # destroy vm0
- self.vm0.stop()
self.vm_env_done = False
+
+
+
def test_stop_restart(self):
"""
Stop and Restar.
--
1.8.3.1
[-- Attachment #2: TestShutdownApi.log --]
[-- Type: application/octet-stream, Size: 161678 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1] tests/TestSuite_shutdown_api:Modify the execution order of shutting down the VM environment
2020-07-03 3:07 [dts] [PATCH V1] tests/TestSuite_shutdown_api:Modify the execution order of shutting down the VM environment xizhan4x
2020-07-03 3:10 ` Zhang, XiX
@ 2020-07-20 6:55 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-07-20 6:55 UTC (permalink / raw)
To: Zhang, XiX, dts; +Cc: Zhang, XiX
Applied, thanks
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of xizhan4x
> Sent: 2020年7月3日 11:08
> To: dts@dpdk.org
> Cc: Zhang, XiX <xix.zhang@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_shutdown_api:Modify the execution
> order of shutting down the VM environment
>
> Modify the execution order of shutting down the VM environment, The correct
> step should be to shut down the VM environment before unbind Vf
>
>
> Signed-off-by: xizhan4x <xix.zhang@intel.com>
> ---
> tests/TestSuite_shutdown_api.py | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
> index 650ccfc..9fc3e3a 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -296,6 +296,16 @@ class TestShutdownApi(TestCase):
>
>
> def destroy_vm_env(self):
> + if getattr(self, 'self.vm0_testpmd', None):
> + self.vm0_testpmd.quit()
> +
> + if getattr(self, 'vm0', None):
> + if getattr(self, 'vm0_dut', None):
> + self.vm0_dut.kill_all()
> + self.vm0_testpmd = None
> + self.vm0_dut_ports = None
> + # destroy vm0
> + self.vm0.stop()
> if getattr(self, 'used_dut_port', None) is not None:
> self.dut.destroy_sriov_vfs_by_port(self.used_dut_port)
> self.used_dut_port = None
> @@ -308,18 +318,11 @@ class TestShutdownApi(TestCase):
> if not self.vm_env_done:
> return
>
> - if getattr(self, 'self.vm0_testpmd', None):
> - self.vm0_testpmd.quit()
> -
> - if getattr(self, 'vm0', None):
> - if getattr(self, 'vm0_dut', None):
> - self.vm0_dut.kill_all()
> - self.vm0_testpmd = None
> - self.vm0_dut_ports = None
> - # destroy vm0
> - self.vm0.stop()
> self.vm_env_done = False
>
> +
> +
> +
> def test_stop_restart(self):
> """
> Stop and Restar.
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-20 6:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-03 3:07 [dts] [PATCH V1] tests/TestSuite_shutdown_api:Modify the execution order of shutting down the VM environment xizhan4x
2020-07-03 3:10 ` Zhang, XiX
2020-07-20 6:55 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).