test suite reviews and discussions
 help / color / mirror / Atom feed
From: xizhan4x <xix.zhang@intel.com>
To: dts@dpdk.org
Cc: xizhan4x <xix.zhang@intel.com>
Subject: [dts] [PATCH V1] tests/TestSuite_mac_filter:Fixed multicast_filter failure of a due to the previous case stop test_pmd
Date: Wed, 29 Jul 2020 15:34:56 +0800	[thread overview]
Message-ID: <1596008096-3377-1-git-send-email-xix.zhang@intel.com> (raw)

Fixed multicast_filter failure of a due to the previous case stop test_pmd 

Signed-off-by: xizhan4x <xix.zhang@intel.com>
---
 tests/TestSuite_mac_filter.py | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/tests/TestSuite_mac_filter.py b/tests/TestSuite_mac_filter.py
index b762c91..e491711 100644
--- a/tests/TestSuite_mac_filter.py
+++ b/tests/TestSuite_mac_filter.py
@@ -55,8 +55,14 @@ class TestMacFilter(TestCase):
         self.dutPorts = self.dut.get_ports()
         # Verify that enough ports are available
         self.verify(len(self.dutPorts) >= 1, "Insufficient ports")
-        portMask = utils.create_mask(self.dutPorts[:1])
 
+
+    def set_up(self):
+        """
+        Run before each test case.
+        Nothing to do.
+        """
+        portMask = utils.create_mask(self.dutPorts[:1])
         self.pmdout = PmdOutput(self.dut)
         self.pmdout.start_testpmd("Default", "--portmask=%s" % portMask)
         self.dut.send_expect("set verbose 1", "testpmd> ")
@@ -75,12 +81,6 @@ class TestMacFilter(TestCase):
 
         self.max_mac_addr = utils.regexp(out, "Maximum number of MAC addresses: ([0-9]+)")
 
-    def set_up(self):
-        """
-        Run before each test case.
-        Nothing to do.
-        """
-        pass
 
     def whitelist_send_packet(self, portid, destMac="00:11:22:33:44:55", count=-1):
         """
@@ -144,6 +144,7 @@ class TestMacFilter(TestCase):
         self.verify("received" not in out,
                     "Packet has been received on a new MAC address that has been removed from the port")
         self.dut.send_expect("stop", "testpmd> ")
+        self.dut.send_expect("quit", "# ", 30)
 
     def test_invalid_addresses(self):
         """
@@ -179,6 +180,8 @@ class TestMacFilter(TestCase):
             i = i + 1
 
         self.verify("No space left on device" in out, "added 1 address more than max MAC addresses")
+        self.dut.send_expect("stop", "testpmd> ")
+        self.dut.send_expect("quit", "# ", 30)
 
     def test_multicast_filter(self):
         """
@@ -206,6 +209,7 @@ class TestMacFilter(TestCase):
                     "Packet has been received when it should have ignored the broadcast")
 
         self.dut.send_expect("stop", "testpmd> ")
+        self.dut.send_expect("quit", "# ", 30)
 
     def tear_down(self):
         """
-- 
1.8.3.1


             reply	other threads:[~2020-07-29  7:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29  7:34 xizhan4x [this message]
2020-07-29  7:35 ` Zhang, XiX
2020-08-12  5:44 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1596008096-3377-1-git-send-email-xix.zhang@intel.com \
    --to=xix.zhang@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).