test suite reviews and discussions
 help / color / mirror / Atom feed
From: Zhou Jun <junx.w.zhou@intel.com>
To: dts@dpdk.org
Cc: Zhou Jun <junx.w.zhou@intel.com>
Subject: [dts] [PATCH V2] tests/malicious_driver_event_indication:code for optimizing the start mode of VF
Date: Wed, 24 Mar 2021 10:25:46 +0800	[thread overview]
Message-ID: <1616552746-21134-1-git-send-email-junx.w.zhou@intel.com> (raw)

v1:
the original way:copy testpmd to another file and start VF
now:start VF with another profix file on the testpmd start PF 

v2:
modifying nonstandard variable naming

Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>
---
 .../TestSuite_malicious_driver_event_indication.py | 43 ++++++++--------------
 1 file changed, 15 insertions(+), 28 deletions(-)

diff --git a/tests/TestSuite_malicious_driver_event_indication.py b/tests/TestSuite_malicious_driver_event_indication.py
index 44859ab..8b446cf 100644
--- a/tests/TestSuite_malicious_driver_event_indication.py
+++ b/tests/TestSuite_malicious_driver_event_indication.py
@@ -38,6 +38,7 @@ import re
 import time
 import traceback
 from contextlib import contextmanager
+from pmd_output import PmdOutput
 
 
 from exception import VerifyFailure
@@ -159,28 +160,12 @@ class TestSuiteMaliciousDrvEventIndication(TestCase):
     def init_vf_testpmd(self):
         self.vf_pmd_session_name = 'vf_testpmd'
         self.vf_pmd_session = self.dut.create_session(self.vf_pmd_session_name)
-        self.vf_testpmd = "{}/{}/app/testpmd_vf".format(
-            self.target_dir, self.dut.target)
-        cmd = 'rm -f {vf_pmd};cp -f {pf_pmd} {vf_pmd}'.format(
-            **{'pf_pmd': self.pf_testpmd, 'vf_pmd': self.vf_testpmd})
-        self.d_a_con(cmd)
+        self.vf_pmdout = PmdOutput(self.dut, self.vf_pmd_session)
 
     def start_vf_testpmd(self):
-        core_mask = utils.create_mask(self.vf_pmd_cores)
-        cmd = (
-            "{bin} "
-            "-v "
-            "-c {core_mask} "
-            "-n {mem_channel} "
-            "--file-prefix={prefix} "
-            "{whitelist} "
-            "-- -i ").format(**{
-                'bin': self.vf_testpmd,
-                'core_mask': core_mask,
-                'mem_channel': self.dut.get_memory_channels(),
-                'whitelist': self.vf_pmd_whitelist,
-                'prefix': 'vf_pmd', })
-        self.vf_pmd_con([cmd, "testpmd> ", 120])
+        self.vf_pmdout.start_testpmd(self.vf_pmd_cores,
+                                     eal_param="-v {}".format(self.vf_pmd_allowlst),
+                                     prefix='vf_pmd')
         self.is_vf_pmd_on = True
         cmds = [
             'set fwd txonly',
@@ -269,7 +254,7 @@ class TestSuiteMaliciousDrvEventIndication(TestCase):
         corelist = self.dut.get_core_list("1S/6C/1T", socket=socket)[2:]
         self.pf_pmd_whitelist = '-w ' + self.vf_ports_info[0].get('pf_pci')
         self.pf_pmd_cores = corelist[:2]
-        self.vf_pmd_whitelist = '-w ' + self.vf_ports_info[0].get('vfs_pci')[0]
+        self.vf_pmd_allowlst = '-w ' + self.vf_ports_info[0].get('vfs_pci')[0]
         self.vf_pmd_cores = corelist[2:]
 
     def init_params(self):
@@ -278,11 +263,6 @@ class TestSuiteMaliciousDrvEventIndication(TestCase):
 
     def preset_test_environment(self):
         self.preset_dpdk_compilation()
-        self.init_pf_testpmd()
-        self.init_vf_testpmd()
-        self.vf_create()
-        # get socket and cores
-        self.preset_pmd_res()
 
     def destroy_resource(self):
         with self.restore_dpdk_compilation():
@@ -297,7 +277,6 @@ class TestSuiteMaliciousDrvEventIndication(TestCase):
         """
         Run at the start of each test suite.
         """
-        self.init_params()
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 1, "Not enough ports")
         self.verify_supported_nic()
@@ -314,13 +293,21 @@ class TestSuiteMaliciousDrvEventIndication(TestCase):
         """
         Run before each test case.
         """
-        pass
+        self.init_params()
+        self.init_pf_testpmd()
+        self.init_vf_testpmd()
+        self.vf_create()
+        self.preset_pmd_res()
 
     def tear_down(self):
         """
         Run after each test case.
         """
         self.dut.kill_all()
+        self.vf_destroy()
+        if self.vf_pmd_session:
+            self.dut.close_session(self.vf_pmd_session)
+            self.vf_pmd_session = None
 
     def test_malicious_driver_event_detected(self):
         """
-- 
1.8.3.1


             reply	other threads:[~2021-03-24  2:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24  2:25 Zhou Jun [this message]
2021-03-24  3:16 ` Zhou, JunX W
2021-03-25  5:58   ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1616552746-21134-1-git-send-email-junx.w.zhou@intel.com \
    --to=junx.w.zhou@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).