test suite reviews and discussions
 help / color / mirror / Atom feed
From: Zhimin Huang <zhiminx.huang@intel.com>
To: dts@dpdk.org
Cc: Zhimin Huang <zhiminx.huang@intel.com>
Subject: [dts] [PATCH V1 1/2] tests/cvl_dcf_acl_filter: remove replace pkg code
Date: Tue, 30 Mar 2021 16:44:46 +0800
Message-ID: <1617093887-25137-2-git-send-email-zhiminx.huang@intel.com> (raw)
In-Reply-To: <1617093887-25137-1-git-send-email-zhiminx.huang@intel.com>

*.update testplan pkg support and remove replace pkg in script

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 test_plans/cvl_dcf_acl_filter_test_plan.rst |  6 ++----
 tests/TestSuite_cvl_dcf_acl_filter.py       | 16 ----------------
 2 files changed, 2 insertions(+), 20 deletions(-)

diff --git a/test_plans/cvl_dcf_acl_filter_test_plan.rst b/test_plans/cvl_dcf_acl_filter_test_plan.rst
index e9267a5..cdccb69 100644
--- a/test_plans/cvl_dcf_acl_filter_test_plan.rst
+++ b/test_plans/cvl_dcf_acl_filter_test_plan.rst
@@ -57,11 +57,9 @@ Prerequisites
    dpdk: http://dpdk.org/git/dpdk
    scapy: http://www.secdev.org/projects/scapy/
 
-3. Copy specific ice package to /lib/firmware/updates/intel/ice/ddp/ice.pkg,
-   then load driver::
+3. Support ice pkg::
 
-    rmmod ice
-    insmod ice.ko
+    os default/comms/wireless
 
 4. Compile DPDK::
 
diff --git a/tests/TestSuite_cvl_dcf_acl_filter.py b/tests/TestSuite_cvl_dcf_acl_filter.py
index 826da9c..1d516fc 100644
--- a/tests/TestSuite_cvl_dcf_acl_filter.py
+++ b/tests/TestSuite_cvl_dcf_acl_filter.py
@@ -749,12 +749,6 @@ class CVLDCFACLFilterTest(TestCase):
         self.testpmd_status = "close"
         #bind pf to kernel
         self.bind_nics_driver(self.dut_ports, driver="ice")
-        #move comms package to package folder
-        self.suite_config = rfc.get_suite_config(self)
-        comms_package_location = self.suite_config["comms_package_file_location"]
-        package_location = self.suite_config["package_file_location"]
-        self.dut.send_expect("cp %s %s" % (comms_package_location, package_location), "# ")
-        self.re_load_ice_driver()
         #set vf driver
         self.vf_driver = 'vfio-pci'
         self.dut.send_expect("modprobe uio", "# ")
@@ -784,16 +778,6 @@ class CVLDCFACLFilterTest(TestCase):
             port.bind_driver(self.vf_driver)
         time.sleep(15)
 
-    def re_load_ice_driver(self):
-        """
-        remove and reload the ice driver
-        """
-        ice_driver_file_location = self.suite_config["ice_driver_file_location"]
-        self.dut.send_expect("rmmod ice", "# ", 60)
-        self.dut.send_expect("insmod %s" % ice_driver_file_location, "# ", 60)
-        self.dut.send_expect("ifconfig %s up" % self.pf0_intf, "# ", 15)
-        self.dut.send_expect("ifconfig %s up" % self.tester_iface0, "# ", 15)
-
     def set_up(self):
         """
         Run before each test case.
-- 
1.8.3.1


  reply	other threads:[~2021-03-30  8:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30  8:44 [dts] [PATCH V1 0/2] " Zhimin Huang
2021-03-30  8:44 ` Zhimin Huang [this message]
2021-03-30 10:04   ` [dts] [PATCH V1 1/2] tests/cvl_dcf_acl_filter: " Huang, ZhiminX
2021-03-30  8:44 ` [dts] [PATCH V1 2/2] tests/cvl_limit_value_test: " Zhimin Huang
2021-03-30 10:07   ` Huang, ZhiminX
2021-04-07  1:05 ` [dts] [PATCH V1 0/2] " Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1617093887-25137-2-git-send-email-zhiminx.huang@intel.com \
    --to=zhiminx.huang@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git