test suite reviews and discussions
 help / color / mirror / Atom feed
From: Zhimin Huang <zhiminx.huang@intel.com>
To: dts@dpdk.org
Cc: Zhimin Huang <zhiminx.huang@intel.com>
Subject: [dts] [PATCH V1 2/2] tests/cvl_limit_value_test: remove replace pkg code
Date: Tue, 30 Mar 2021 16:44:47 +0800
Message-ID: <1617093887-25137-3-git-send-email-zhiminx.huang@intel.com> (raw)
In-Reply-To: <1617093887-25137-1-git-send-email-zhiminx.huang@intel.com>

*.update test plan support pkg and remove replace pkg in script

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 test_plans/cvl_limit_value_test_test_plan.rst |  5 +++--
 tests/TestSuite_cvl_limit_value_test.py       | 15 ---------------
 2 files changed, 3 insertions(+), 17 deletions(-)

diff --git a/test_plans/cvl_limit_value_test_test_plan.rst b/test_plans/cvl_limit_value_test_test_plan.rst
index 8c8402e..242eb9a 100644
--- a/test_plans/cvl_limit_value_test_test_plan.rst
+++ b/test_plans/cvl_limit_value_test_test_plan.rst
@@ -66,8 +66,9 @@ Prerequisites
    DPDK: http://dpdk.org/git/dpdk
    scapy: http://www.secdev.org/projects/scapy/
 
-3. Copy specific ice package to /lib/firmware/intel/ice/ddp/ice.pkg
-   Then reboot server, and compile DPDK
+3. Support ice pkg::
+
+    os default/comms/wireless
 
 4. Generate 2 VFs on each PF and set mac address for each VF::
 
diff --git a/tests/TestSuite_cvl_limit_value_test.py b/tests/TestSuite_cvl_limit_value_test.py
index 77ce016..b806474 100644
--- a/tests/TestSuite_cvl_limit_value_test.py
+++ b/tests/TestSuite_cvl_limit_value_test.py
@@ -189,15 +189,6 @@ class TestCvlLimitValue(TestCase):
         self.dut.destroy_sriov_vfs_by_port(self.dut_ports[0])
         self.dut.destroy_sriov_vfs_by_port(self.dut_ports[1])
 
-    def re_load_ice_driver(self):
-        """
-        remove and reload the ice driver
-        """
-        ice_driver_file_location = self.suite_config["ice_driver_file_location"]
-        self.dut.send_expect("rmmod ice", "# ", 15)
-        self.dut.send_expect("insmod %s" % ice_driver_file_location, "# ", 60)
-        time.sleep(5)
-
     def config_testpmd(self):
         self.pmd_output.execute_cmd("set fwd rxonly")
         self.pmd_output.execute_cmd("set verbose 1")
@@ -813,12 +804,6 @@ class TestCvlLimitValue(TestCase):
     def test_max_rule_number(self):
         #bind pf to kernel
         self.bind_nics_driver(self.dut_ports, driver="ice")
-        #move comms package to package folder
-        self.suite_config = rfc.get_suite_config(self)
-        comms_package_location = self.suite_config["comms_package_file_location"]
-        package_location = self.suite_config["package_file_location"]
-        self.dut.send_expect("cp %s %s" % (comms_package_location, package_location), "# ")
-        self.re_load_ice_driver()
         #set vf driver
         self.vf_driver = 'vfio-pci'
         self.dut.send_expect('modprobe vfio-pci', '#')
-- 
1.8.3.1


  parent reply	other threads:[~2021-03-30  8:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30  8:44 [dts] [PATCH V1 0/2] " Zhimin Huang
2021-03-30  8:44 ` [dts] [PATCH V1 1/2] tests/cvl_dcf_acl_filter: " Zhimin Huang
2021-03-30 10:04   ` Huang, ZhiminX
2021-03-30  8:44 ` Zhimin Huang [this message]
2021-03-30 10:07   ` [dts] [PATCH V1 2/2] tests/cvl_limit_value_test: " Huang, ZhiminX
2021-04-07  1:05 ` [dts] [PATCH V1 0/2] " Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1617093887-25137-3-git-send-email-zhiminx.huang@intel.com \
    --to=zhiminx.huang@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git