test suite reviews and discussions
 help / color / mirror / Atom feed
From: Lijuan Tu <lijuan.tu@intel.com>
To: ohilyard@iol.unh.edu, dliu@iol.unh.edu
Cc: dts@dpdk.org, Lijuan Tu <lijuan.tu@intel.com>
Subject: [dts] [PATCH] Revert "Strip prompt by default in send_expect"
Date: Thu, 13 May 2021 00:12:01 +0800
Message-ID: <1620835921-182513-1-git-send-email-lijuan.tu@intel.com> (raw)

This reverts commit f498f50a62e30f6f8fb9c4e1a759e3d35861b978.
As it casued some cases failed:
  * flow_classify_softnic
      * test_ipv4_acl_jump
      * test_ipv4_acl_table
      * test_ipv6_hash_jump
  * unit_tests_loopback
      * test_link_mode
      * test_loopback_mode
  * distributor
      * maximum_workers
---
 framework/crb.py | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/framework/crb.py b/framework/crb.py
index 3964e21..e7c1cc1 100644
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -79,19 +79,12 @@ class Crb(object):
             self.alt_session = None
 
     def send_expect(self, cmds, expected, timeout=TIMEOUT,
-                    alt_session=False, verify=False, trim_whitespace=True):
+                    alt_session=False, verify=False):
         """
         Send commands to crb and return string before expected string. If
         there's no expected string found before timeout, TimeoutException will
         be raised.
-
-        By default, it will trim the whitespace from the expected string. This
-        behavior can be turned off via the trim_whitespace argument.
         """
-
-        if trim_whitespace:
-            expected = expected.strip()
-
         # sometimes there will be no alt_session like VM dut
         if alt_session and self.alt_session:
             return self.alt_session.session.send_expect(cmds, expected,
-- 
1.8.3.1


             reply	other threads:[~2021-05-12  8:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 16:12 Lijuan Tu [this message]
2021-05-12  8:19 ` Tu, Lijuan
2021-05-26 12:23 ` David Marchand
2021-05-26 14:24   ` Owen Hilyard
2021-06-02  7:36   ` David Marchand
2021-06-02  7:41     ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1620835921-182513-1-git-send-email-lijuan.tu@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dliu@iol.unh.edu \
    --cc=dts@dpdk.org \
    --cc=ohilyard@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git