From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38717A00C2; Tue, 17 May 2022 08:49:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2079B4068B; Tue, 17 May 2022 08:49:01 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 7C60B40041 for ; Tue, 17 May 2022 08:48:59 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id BBC255C0125; Tue, 17 May 2022 02:48:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 17 May 2022 02:48:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652770138; x= 1652856538; bh=WZWqKCBUkxxIg4si42B+HcUUxUG+CnOs8w+++4kagSw=; b=A /YxJ0ZR5vb480YdryP7b7mIdpKG7dWdEfJ2jIhspXmvLeCaYqjiWJkKJVP7xbSx4 wigd/IFl/H8mImE7tgeuHLC5SElgfQ0Bwk1MJPvvc3kSKnGzuNl7yntOBHx0XNEX 8LlasFnoLI0/4+EGAeRsbkgkD7SuFDboX1CAIGKohiT7pfBJoQG4ezhWOBdtyxL3 PYFJAUQX4Zu6gIRfAjd60wjYL4RU63IX7B471cLNh1k5IYxjNYLUSZ9MDUyCUkBi Dqae051EZkPDuXssIG7vkP3GCaowWxxcO20ww/AFzlMqn+ktFppkM3PR/VRIBJG8 q6Zoae7dTHbKqrSB9RK5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652770138; x= 1652856538; bh=WZWqKCBUkxxIg4si42B+HcUUxUG+CnOs8w+++4kagSw=; b=S VuCvXsQbYWzzTFtVOcsuwdgvLuc23VR9Y+jbuDSEvFTQl7eOnIGG/5kGsUPJEmJ7 0K1QIb4XqfnDjNsDiQ0cqF/PkwgHGOscQIfnTv/68XrpwSrceJmJL/gKa/DR9cD1 bULRoIUINy7v+xmkxwifFTNc9lLjD6ul3h75NwhKVdU5XT6QEK3lPi+ETnx9LDBd xJqbT4eyNVFGcKLhOBQIS02K0gzPY3qBogp6BTaki/jHHAaSZlOZh18CZ7v3JGqf dncufYCpMyg8M4enZmaEPDyhJtvAIMqrceq6g67/eBY3vvHkgeQWzid6v343KWFK +CisWNYdzW3jcC9773wQQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheeigdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 May 2022 02:48:56 -0400 (EDT) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= , "lijuan.tu@intel.com" , "ohilyard@iol.unh.edu" , Honnappa Nagarahalli Cc: "dts@dpdk.org" , David Marchand , nd , "bruce.richardson@intel.com" Subject: Re: [PATCH v1] cleanup: rename base classes Date: Tue, 17 May 2022 08:48:47 +0200 Message-ID: <16365457.Ash8RoxBsO@thomas> In-Reply-To: References: <20220516133340.1056427-1-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org > > The current naming of the base elements DTS works with is a bit > > confusing, which this patch attemps to ameliorate. The basic elements > > could be divided into and described in short as follows: > > * A node: a broad term encompassing a host where any of the DTS elements > > are present. This could be a physical or virtualized server or a > > container. OK > > * The control node: the host where DTS runs OK > > * An SUT (system under test) node: This is where DPDK along with the > > tested hardware resides. The system comprises DPDK and the hardware. Is there any difference between a SUT and a "tested node"? > > * A traffic generator node: The node where the traffic generator is > > present, such as Trex, Scapy or a hardware traffic generator (e.g. IXIA) OK > > All references to DUT were removed. This is because it was used to mean > > both the server where DPDK/NIC are present and the DUT (device under > > test, i.e. the NIC) in different contexts. Where applicable, DUT was > > replaced with NIC and the rest were replaced with SUT. With this change, > > it's clear what's meant and the abbreviations are very different, which > > removes that layer of confusion. "NIC" does not mean it is a device under test. Also we could have other kind of devices under test, like crypto cards. > > Rename the following classes: > > Crb -> Node > > Dut -> SutNode > > Tester -> TrafficGeneratorNode > > DPDKdut -> DpdkSut > > DPDKtester -> DpdkTrafficGenerator > > VirtDut -> VirtSut > > CrbsConf -> TopologyConf > > PktgenConf -> PacketGeneratorConf I think you need to choose between "TrafficGenerator" and "PacketGenerator".