From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93B92A0548; Fri, 12 Nov 2021 03:51:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FFD640692; Fri, 12 Nov 2021 03:51:03 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id D5A9A40687 for ; Fri, 12 Nov 2021 03:51:01 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10165"; a="293886819" X-IronPort-AV: E=Sophos;i="5.87,227,1631602800"; d="scan'208";a="293886819" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2021 18:51:01 -0800 X-IronPort-AV: E=Sophos;i="5.87,227,1631602800"; d="scan'208";a="492802457" Received: from unknown (HELO localhost.localdomain) ([10.240.183.163]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 Nov 2021 18:50:58 -0800 From: Yu Jiang To: yuan.peng@intel.com, dts@dpdk.org Cc: Yu Jiang Subject: [dts][PATCH V1] tests/pmdrss_hash: remove case test_dynamic_rss_bond_config Date: Fri, 12 Nov 2021 10:50:37 +0800 Message-Id: <1636685437-11412-1-git-send-email-yux.jiang@intel.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org According to dpdk commit id 81db321da ("ethdev: remove legacy HASH filter type support"), No new rte_flow_api support get_hash_global_config, so remove this case. Signed-off-by: Yu Jiang --- test_plans/pmdrss_hash_test_plan.rst | 32 ----------------------------- tests/TestSuite_pmdrss_hash.py | 40 ------------------------------------ 2 files changed, 72 deletions(-) diff --git a/test_plans/pmdrss_hash_test_plan.rst b/test_plans/pmdrss_hash_test_plan.rst index 48a61e5..777115b 100644 --- a/test_plans/pmdrss_hash_test_plan.rst +++ b/test_plans/pmdrss_hash_test_plan.rst @@ -183,35 +183,3 @@ Test Case: test_simple_symmetric The same as the above test case "test_toeplitz_symmetric". Just pay attention to set the hash function to "simple xor" -Test Case: test_dynamic_rss_bond_config -======================================== -This case test bond slaves will auto sync rss hash config, it only support by fortville. - -#. set up testpmd with fortville NICs:: - - ./testpmd -c f -n 4 -- -i - -#. create bond device with mode 3:: - - create bonded device 3 0 - -#. add slave to bond device:: - - add bonding slave 0 2 - add bonding slave 1 2 - -#. get default hash algorithm on slave:: - - get_hash_global_config 0 - get_hash_global_config 1 - -#. set hash algorithm on slave 0:: - - set_hash_global_config 0 simple_xor ipv4-other enable - -#. get hash algorithm on slave 0 and 1:: - - get_hash_global_config 0 - get_hash_global_config 1 - -#. check slave 0 and 1 use same hash algorithm diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py index 9eb17cf..309e1b9 100644 --- a/tests/TestSuite_pmdrss_hash.py +++ b/tests/TestSuite_pmdrss_hash.py @@ -625,46 +625,6 @@ class TestPmdrssHash(TestCase): self.dut.send_expect("quit", "# ", 30) - def test_dynamic_rss_bond_config(self): - - # setup testpmd and finish bond config - self.verify(self.nic in ["columbiaville_25g", "columbiaville_100g","fortville_eagle", "fortville_spirit", - "fortpark_TLV","fortpark_BASE-T", "fortville_25g", "carlsville", "foxville"], - "NIC Unsupported: " + str(self.nic)) - - self.dut.send_expect("%s %s -- -i" % (self.path, self.eal_para), "testpmd> ", 120) - self.dut.send_expect("set promisc all off", "testpmd> ") - out = self.dut.send_expect("create bonded device 3 0", "testpmd> ", 30) - bond_device_id = int(re.search("port \d+", out).group().split(" ")[-1].strip()) - - self.dut.send_expect("add bonding slave 0 %d" % bond_device_id, "testpmd>", 30) - self.dut.send_expect("add bonding slave 1 %d" % bond_device_id, "testpmd>", 30) - - # get slave device default rss hash algorithm - out = self.dut.send_expect("get_hash_global_config 0", "testpmd>") - slave0_hash_function = re.search("Hash function is .+", out).group().split(" ")[-1].strip() - out = self.dut.send_expect("get_hash_global_config 1", "testpmd>") - slave1_hash_function = re.search("Hash function is .+", out).group().split(" ")[-1].strip() - self.verify(slave0_hash_function == slave1_hash_function, "default hash function not match") - - new_hash_function = "" - for hash_function in ["toeplitz", "simple_xor"]: - if slave0_hash_function[-3:].lower() != hash_function[-3:]: - new_hash_function = hash_function - # update slave 0 rss hash algorithm and get slave 0 and slave 1 rss new hash algorithm - self.dut.send_expect("set_hash_global_config 0 %s ipv4-other enable" % new_hash_function, "testpmd>") - out = self.dut.send_expect("get_hash_global_config 0", "testpmd>") - slave0_new_hash_function = re.search("Hash function is .+", out).group().split(" ")[-1].strip() - out = self.dut.send_expect("get_hash_global_config 1", "testpmd>") - slave1_new_hash_function = re.search("Hash function is .+", out).group().split(" ")[-1].strip() - - self.verify(slave0_new_hash_function == slave1_new_hash_function, "bond slave auto sync hash function failed") - self.verify(slave0_new_hash_function[-3:].lower() == new_hash_function[-3:], "changed slave hash function failed") - - self.dut.send_expect("remove bonding slave 0 %d" % bond_device_id, "testpmd>", 30) - self.dut.send_expect("remove bonding slave 1 %d" % bond_device_id, "testpmd>", 30) - self.dut.send_expect("quit","# ", 30) - def tear_down(self): """ Run after each test case. -- 2.7.4