test suite reviews and discussions
 help / color / mirror / Atom feed
From: Juraj Linkeš <juraj.linkes@pantheon.tech>
To: lijuan.tu@intel.com, ohilyard@iol.unh.edu
Cc: dts@dpdk.org, Juraj Linkeš <juraj.linkes@pantheon.tech>
Subject: [PATCH v1] framework/project_dpdk: fix pylama errors
Date: Mon,  6 Dec 2021 13:21:09 +0100
Message-ID: <1638793269-2769-1-git-send-email-juraj.linkes@pantheon.tech> (raw)

Pylama found the following errors:
framework/project_dpdk.py:292: [E] E1101 Instance of 'DPDKdut' has no 'host_dut' member [pylint]
framework/project_dpdk.py:293: [E] E1101 Instance of 'DPDKdut' has no 'host_dut' member [pylint]
framework/project_dpdk.py:294: [E] E1101 Instance of 'DPDKdut' has no 'host_dut' member [pylint]
framework/project_dpdk.py:421: [E] E1101 Instance of 'DPDKdut' has no 'host_dut' member [pylint]

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
Lijuan, please add additional people to review if needed.
---
 framework/project_dpdk.py | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
index 9927bcc1..6001d8a4 100644
--- a/framework/project_dpdk.py
+++ b/framework/project_dpdk.py
@@ -286,15 +286,6 @@ class DPDKdut(Dut):
         shared_lib_path = load_global_setting(HOST_SHARED_LIB_PATH)
         if use_shared_lib == 'true' and 'Virt' not in str(self):
             self.set_build_options({'RTE_BUILD_SHARED_LIB': 'y'})
-        kernel_driver = ''
-        nic_name = ''
-        if 'Virt' in str(self):
-            if self.host_dut.nic:
-                kernel_driver = self.host_dut.nic.default_driver
-                nic_name = self.host_dut.nic.name
-        elif self.nic:
-            kernel_driver = self.nic.default_driver
-            nic_name = self.nic.name
 
         build_type = load_global_setting(HOST_BUILD_TYPE_SETTING)
         build_install_dpdk = getattr(self, 'build_install_dpdk_%s_%s' % (self.get_os_type(), build_type))
@@ -418,7 +409,7 @@ class DPDKdut(Dut):
                                     "--snapshot when run dts")
                 # if ':' in session, this is vm dut, use the dut session
                 if ':' in self.session.name:
-                    session_info = self.host_dut.alt_session
+                    session_info = self.crb.alt_session
                 else:
                      session_info = self.alt_session
                 out = session_info.send_expect('ls -F %s' % self.package, '# ')
-- 
2.20.1


             reply	other threads:[~2021-12-06 12:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06 12:21 Juraj Linkeš [this message]
2022-01-19 12:54 ` [PATCH v2] " Juraj Linkeš
2022-01-25  5:32   ` Dong, JunX
2022-01-25  5:57     ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1638793269-2769-1-git-send-email-juraj.linkes@pantheon.tech \
    --to=juraj.linkes@pantheon.tech \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=ohilyard@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git