test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: lijuan.tu@intel.com, ohilyard@iol.unh.edu
Cc: dts@dpdk.org, "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Subject: [PATCH v2] framework/pktgen_*: fix pylama errors
Date: Tue,  7 Dec 2021 16:04:43 +0100	[thread overview]
Message-ID: <1638889483-6273-1-git-send-email-juraj.linkes@pantheon.tech> (raw)
In-Reply-To: <1637761668-4060-1-git-send-email-juraj.linkes@pantheon.tech>

Pylama found the following errors:
framework/pktgen_base.py:108: [E] E1101 Instance of 'PacketGenerator' has no '_get_gen_port' member [pylint]
framework/pktgen_base.py:148: [E] E1101 Instance of 'PacketGenerator' has no '_clear_streams' member; maybe 'clear_streams'? [pylint]
framework/pktgen_base.py:173: [E] E1101 Instance of 'PacketGenerator' has no 'pktgen_type' member [pylint]
framework/pktgen_base.py:279: [E] E1101 Instance of 'PacketGenerator' has no 'pktgen_type' member [pylint]
framework/pktgen_base.py:479: [E] E1101 Instance of 'PacketGenerator' has no '_clear_streams' member; maybe 'clear_streams'? [pylint]
framework/pktgen_base.py:528: [E] E0602 Undefined variable 'last_no_lost_mult' [pylint]
framework/pktgen_base.py:558: [E] E1101 Instance of 'PacketGenerator' has no 'pktgen_type' member [pylint]
framework/pktgen_base.py:573: [E] E1101 Instance of 'PacketGenerator' has no '_clear_streams' member; maybe 'clear_streams'? [pylint]
framework/pktgen_base.py:607: [E] E1101 Instance of 'PacketGenerator' has no '_clear_streams' member; maybe 'clear_streams'? [pylint]
framework/pktgen_base.py:673: [E] E1101 Instance of 'PacketGenerator' has no 'pktgen_type' member [pylint]
framework/pktgen_base.py:677: [E] E1101 Instance of 'PacketGenerator' has no 'pktgen_type' member [pylint]
framework/pktgen_base.py:69: [E] E1101 Instance of 'PacketGenerator' has no '_prepare_generator' member; maybe 'prepare_generator'? [pylint]
framework/pktgen_base.py:77: [E] E1101 Instance of 'PacketGenerator' has no '_get_port_pci' member [pylint]
framework/pktgen_ixia.py:1085: [E] E1306 Not enough arguments for format string [pylint]
framework/pktgen_trex.py:194: [E] E0602 Undefined variable 'Ether' [pylint]
framework/pktgen_trex.py:195: [E] E0602 Undefined variable 'IP' [pylint]

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Lijuan, please add additional people to review if needed.
 framework/pktgen_base.py | 15 ++++++++++++++-
 framework/pktgen_ixia.py |  2 +-
 framework/pktgen_trex.py |  5 ++++-
 3 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/framework/pktgen_base.py b/framework/pktgen_base.py
index 023652cc..16eae93f 100644
--- a/framework/pktgen_base.py
+++ b/framework/pktgen_base.py
@@ -64,10 +64,17 @@ class PacketGenerator(object):
         self.tester = tester
         self.__streams = []
         self._ports_map = []
+        self.pktgen_type = None
+    def _prepare_generator(self):
+        raise NotImplementedError
     def prepare_generator(self):
+    def _get_port_pci(self, port_id):
+        raise NotImplementedError
     def _convert_pktgen_port(self, port_id):
         :param port_id:
@@ -94,6 +101,9 @@ class PacketGenerator(object):
         return port
+    def _get_gen_port(self, tester_pci):
+        raise NotImplementedError
     def _convert_tester_port(self, port_id):
         :param port_id:
@@ -143,6 +153,9 @@ class PacketGenerator(object):
     def get_streams(self):
         return self.__streams
+    def _clear_streams(self):
+        raise NotImplementedError
     def clear_streams(self):
         ''' clear streams '''
@@ -525,7 +538,7 @@ class PacketGenerator(object):
             pps = (traffic_pps_max - traffic_pps_min)/2 + traffic_pps_min
-        self.logger.info("zero loss pps is %f" % last_no_lost_mult)
+        self.logger.info("zero loss pps is %f" % pps)
         # use last result as return data to keep the same with dts/etgen format
         # In fact, multiple link peer have multiple loss rate value,
         # here only pick one
diff --git a/framework/pktgen_ixia.py b/framework/pktgen_ixia.py
index 06667047..9a8c9d2e 100644
--- a/framework/pktgen_ixia.py
+++ b/framework/pktgen_ixia.py
@@ -1082,7 +1082,7 @@ class Ixia(SSHConnection):
         Tells IXIA to prepare the internal buffers were the frames were captured.
         ixia_port = self.get_ixia_port(port_number)
-        command = 'capture get {0} {1} {2}'.format(ixia_port)
+        command = 'capture get {0}'.format(ixia_port)
         self.send_expect(command, '% ', 30)
     def stat_get_rate_stat_all_stats(self, port_number):
diff --git a/framework/pktgen_trex.py b/framework/pktgen_trex.py
index 2ad05fe6..2f537a0b 100644
--- a/framework/pktgen_trex.py
+++ b/framework/pktgen_trex.py
@@ -35,6 +35,9 @@ import sys
 import time
 from pprint import pformat
+from scapy.layers.inet import IP
+from scapy.layers.l2 import Ether
 from .pktgen_base import (
@@ -414,6 +417,7 @@ class TrexPacketGenerator(PacketGenerator):
     def __init__(self, tester):
+        super(TrexPacketGenerator, self).__init__(tester)
         self.pktgen_type = PKTGEN_TREX
         self.trex_app = "t-rex-64"
         self._conn = None
@@ -432,7 +436,6 @@ class TrexPacketGenerator(PacketGenerator):
         self.ip_keys = ['start', 'end','action', 'mask', 'step']
         self.vlan_keys = ['start', 'end', 'action', 'step', 'count']
-        super(TrexPacketGenerator, self).__init__(tester)
         # check trex binary file
         trex_bin = os.sep.join([self.conf.get('trex_root_path'), self.trex_app])

  reply	other threads:[~2021-12-07 15:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 13:47 [PATCH v1] framework/virt_*: " Juraj Linkeš
2021-12-07 15:04 ` Juraj Linkeš [this message]
2021-12-07 15:18   ` [PATCH v3] framework/pktgen_*: " Juraj Linkeš
2022-01-14  8:09     ` Tu, Lijuan
2021-12-08  9:32 ` [PATCH v2] framework/virt_*: " Juraj Linkeš

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1638889483-6273-1-git-send-email-juraj.linkes@pantheon.tech \
    --to=juraj.linkes@pantheon.tech \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=ohilyard@iol.unh.edu \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).