From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 817642BCD for ; Fri, 26 Feb 2016 07:15:34 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 25 Feb 2016 22:15:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="924275072" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 25 Feb 2016 22:15:34 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 25 Feb 2016 22:15:33 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 25 Feb 2016 22:15:32 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0248.002; Fri, 26 Feb 2016 14:15:31 +0800 From: "Pei, Yulong" To: "Tu, LijuanX A" , "Liu, Yong" , "dts@dpdk.org" , "Xu, Qian Q" Thread-Topic: [dts][PATCH]tests vf_port_start_stop: update test case Thread-Index: AQHRcFUJ4x40tFp5B0qwFuf+L9AeEJ892TVg Date: Fri, 26 Feb 2016 06:15:30 +0000 Message-ID: <188971FCDA171749BED5DA74ABF3E6F00353ACAF@shsmsx102.ccr.corp.intel.com> References: <1456463602-14595-1-git-send-email-lijuanx.a.tu@intel.com> In-Reply-To: <1456463602-14595-1-git-send-email-lijuanx.a.tu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGFiMzU3MjgtZjEyMi00ZWI0LTlmNWItNWRiZWUxMzU0ODNiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZGJ2RWdDMWtwNXNzWlBrdWM5dnhhaWI0ZU1XK3BrczRzWlhVT2dRczFZcz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH]tests vf_port_start_stop: update test case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2016 06:15:35 -0000 Hi Lijuan, I think that maybe we keep checking Rx-errors and ignore this issue for For= tville NIC and regard it as a known issue is better. Best Regards Yulong Pei -----Original Message----- From: Tu, LijuanX A=20 Sent: Friday, February 26, 2016 1:13 PM To: Liu, Yong ; dts@dpdk.org; Pei, Yulong ; Xu, Qian Q Cc: Tu, LijuanX A Subject: [dts][PATCH]tests vf_port_start_stop: update test case Forwarding checking RX-packets, RX-Bytes, Tx-packets, Tx-bytes, Do not chec= king Rx-errors fortville NIC: when not start, the port is ready to RX but NOT RX packets, if you send 119 packets at 64B, then it will be RXed at the NIC's hardw= are buffer if the buffer is full, it will show in RX-errors so we do not verify Rx-errors. Signed-off-by: Lijuan Tu --- tests/TestSuite_vf_port_start_stop.py | 48 ++++++++++++++++++++++---------= ---- 1 file changed, 30 insertions(+), 18 deletions(-) diff --git a/tests/TestSuite_vf_port_start_stop.py b/tests/TestSuite_vf_por= t_start_stop.py index 0cc7ffd..17aa589 100644 --- a/tests/TestSuite_vf_port_start_stop.py +++ b/tests/TestSuite_vf_port_start_stop.py @@ -114,11 +114,19 @@ class TestVfPortStartStop(TestCase): testpmd.execute_cmd('port stop all') testpmd.execute_cmd('clear port stats all') =20 - def check_port_start_stop(self, testpmd, times=3D10): + def check_port_start_stop(self, testpmd, times=3D1000): """ VF port start/stop several times , check if it work well. """ + port_id_0 =3D 0 + port_id_1 =3D 1 + for i in range(times): + vf0_stats =3D self.vm0_testpmd.get_pmd_stats(port_id_0) + b_vf0_rx_pkts, b_vf0_rx_bytes =3D vf0_stats['RX-packets'], vf0= _stats['RX-bytes'] + vf1_stats =3D self.vm0_testpmd.get_pmd_stats(port_id_1) + b_vf1_tx_pkts, b_vf1_tx_bytes =3D vf1_stats['TX-packets'],=20 + vf1_stats['TX-bytes'] + out =3D testpmd.execute_cmd('port start all') self.verify("Checking link statuses" in out, "ERROR: port star= t all") testpmd.execute_cmd('start') @@ -127,22 +135,20 @@ class TestV= fPortStartStop(TestCase): out =3D testpmd.execute_cmd('port stop all') self.verify("Checking link statuses" in out, "ERROR: port stop= all") =20 - port_id_0 =3D 0 - port_id_1 =3D 1 - vf0_stats =3D self.vm0_testpmd.get_pmd_stats(port_id_0) - vf1_stats =3D self.vm0_testpmd.get_pmd_stats(port_id_1) - - vf0_rx_cnt =3D vf0_stats['RX-packets'] - self.verify(vf0_rx_cnt !=3D 0, "no packet was received by vm0_VF0"= ) - - vf0_rx_err =3D vf0_stats['RX-errors'] - self.verify(vf0_rx_err =3D=3D 0, "vm0_VF0 rx-errors") - =20 - vf1_tx_cnt =3D vf1_stats['TX-packets'] - self.verify(vf1_tx_cnt !=3D 0, "no packet was transmitted by vm0_V= F1") - - vf1_tx_err =3D vf1_stats['TX-errors'] - self.verify(vf1_tx_err =3D=3D 0, "vm0_VF0 tx-errors") + vf0_stats =3D self.vm0_testpmd.get_pmd_stats(port_id_0) + c_vf0_rx_pkts, c_vf0_rx_bytes =3D vf0_stats['RX-packets'], vf0= _stats['RX-bytes'] + vf1_stats =3D self.vm0_testpmd.get_pmd_stats(port_id_1) + c_vf1_tx_pkts, c_vf1_tx_bytes =3D vf1_stats['TX-packets'],=20 + vf1_stats['TX-bytes'] + + #Fortville NIC :when not start, the port is ready to RX but NO= T RX packets,=20 + #if you send packets , then it will be RXed at the NIC's hard= ware buffer + #if buffer is full ,it will show RX-errors + #so, we do not check RX-errors + #compare vf0 RX-packets RX-bytes ,vf1 Tx-packets TX-bytes + self.verify(c_vf0_rx_pkts > b_vf0_rx_pkts, "Packets received e= rror") + self.verify(c_vf0_rx_bytes > b_vf0_rx_bytes, "Bytes received e= rror") + self.verify(c_vf1_tx_pkts > b_vf1_tx_pkts, "Packets forwarding= error") + self.verify(c_vf1_tx_bytes > b_vf1_tx_bytes, "Bytes=20 + forvwarding error") =20 def setup_1pf_2vf_1vm_env(self, driver=3D'default'): =20 @@ -215,11 +221,17 @@ class TestVfPortStartStop(TestCase): =20 self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) self.vm0_testpmd.start_testpmd(VM_CORES_MASK) + + self.vm0_testpmd.execute_cmd('port stop all') + self.vm0_testpmd.execute_cmd('port config all crc-strip on') + self.vm0_testpmd.execute_cmd('port start all') self.vm0_testpmd.execute_cmd('set fwd mac') +# self.vm0_testpmd.execute_cmd('start') =20 time.sleep(2) =20 - dst_mac =3D self.vm_dut_0.get_mac_address(self.vm0_dut_ports[0]) + port_id_0 =3D 0 + dst_mac =3D self.vm0_testpmd.get_port_mac(port_id_0) self.send_and_verify(dst_mac, self.vm0_testpmd)=20 =20 def tear_down(self): -- 1.9.3