From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 57407A05D3 for ; Wed, 27 Mar 2019 22:21:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4BC294CBD; Wed, 27 Mar 2019 22:21:56 +0100 (CET) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by dpdk.org (Postfix) with ESMTP id C4E411B05 for ; Wed, 27 Mar 2019 22:21:55 +0100 (CET) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2RLJ4Bb072642 for ; Wed, 27 Mar 2019 17:21:54 -0400 Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rgfjhbu7x-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 27 Mar 2019 17:21:54 -0400 Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Mar 2019 21:21:53 -0000 Received: from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19) by e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 27 Mar 2019 21:21:51 -0000 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x2RLLnEw54722658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Mar 2019 21:21:49 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0E4926E052; Wed, 27 Mar 2019 21:21:49 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BB85C6E04E; Wed, 27 Mar 2019 21:21:48 +0000 (GMT) Received: from oc8377887825.ibm.com (unknown [9.70.82.120]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 27 Mar 2019 21:21:48 +0000 (GMT) From: David Wilder To: dts@dpdk.org Cc: pradeep@us.ibm.com, wilder@us.ibm.com Date: Wed, 27 Mar 2019 14:21:45 -0700 X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19032721-0004-0000-0000-000014F3FD27 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010825; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000282; SDB=6.01180573; UDB=6.00617838; IPR=6.00961291; MB=3.00026185; MTD=3.00000008; XFM=3.00000015; UTC=2019-03-27 21:21:52 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19032721-0005-0000-0000-00008B0D27AC Message-Id: <20190327212145.1978-1-dwilder@us.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-27_13:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=884 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903270147 Subject: [dts] [PATCH V1] tests/coremask: correct Master lcore X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" The "test_all_cores_core-mask sub-test validates that the Master lcore becomes ready, the test assumes this to be core 1, this is not correct for all architectures or all configurations. For example this test will fail on x86_64 with bypass_core0=False and on Power9 with most smt configurations. This patch determines the first (lowest numbered) core from the list of available cores and tests that that core becomes ready. I validated this change that the test will pass on both Power9 and x86_64 with both true and false setting of bypass_core0.o Signed-off-by: David Wilder --- tests/TestSuite_coremask.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/TestSuite_coremask.py b/tests/TestSuite_coremask.py index 921dc31..7299e0c 100644 --- a/tests/TestSuite_coremask.py +++ b/tests/TestSuite_coremask.py @@ -92,14 +92,16 @@ class TestCoremask(TestCase): core_mask = utils.create_mask(self.all_cores[:available_max_lcore - 1]) + first_core=self.all_cores[0] + command = command_line % (self.target, core_mask, self.mem_channel) out = self.dut.send_expect(command, "RTE>>", 10) - self.verify("EAL: Master lcore 1 is ready" in out, - "Core 1 not ready") + self.verify("EAL: Master lcore %s is ready" % first_core in out, + "Core %s not ready" % first_core ) - self.verify("EAL: Detected lcore 1 as core" in out, - "Core 1 not detected") + self.verify("EAL: Detected lcore %s as core" % first_core in out, + "Core %s not detected" % first_core ) for core in self.all_cores[1:available_max_lcore - 1]: self.verify("EAL: lcore %s is ready" % core in out, -- 1.8.3.1