[dts] [PATCH V3 0/2] dts/pktgen: fix missing parameter setting

[dts] [PATCH V3 0/2] dts/pktgen: fix missing parameter setting

[yufengmx]

 These commits are internal bugs fixed, which are reported by ma,lihong 
 
 *. add missing rate percent key of stream config option in pktgen module. 
 *. add missing start traffic option input in measure_throughput method. 
 

v3: 
 -  rebase source code. 
 -  

yufengmx (2):
  framework/pktgen_base: fix measure_throughput missed option input
  framework/pktgen: fix PacketGeneratorHelper missed rate setting

 framework/pktgen.py      | 1 +
 framework/pktgen_base.py | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.21.0

[dts] [PATCH V3 1/2] framework/pktgen_base: fix measure_throughput missed option

[yufengmx]

 input

add missing _start_transmission options input in measure_throughput method.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 framework/pktgen_base.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/pktgen_base.py b/framework/pktgen_base.py
index 06ad738..4cb5447 100644
--- a/framework/pktgen_base.py
+++ b/framework/pktgen_base.py
@@ -170,7 +170,7 @@ class PacketGenerator(object):
         bps_rx = []
         pps_rx = []
         self._prepare_transmission(stream_ids=stream_ids)
-        self._start_transmission(stream_ids)
+        self._start_transmission(stream_ids, options)
 
         delay = options.get('delay') or 5
         time.sleep(delay)
-- 
2.21.0

Re: [dts] [PATCH V3 1/2] framework/pktgen_base: fix measure_throughput missed option

[Tu, Lijuan]

Applied, thanks

> -----Original Message-----
> From: Mo, YufengX
> Sent: Friday, September 20, 2019 10:19 AM
> To: dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com>; Tu, Lijuan
> <lijuan.tu@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V3 1/2] framework/pktgen_base: fix
> measure_throughput missed option
> 
>  input
> 
> add missing _start_transmission options input in measure_throughput
> method.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  framework/pktgen_base.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/pktgen_base.py b/framework/pktgen_base.py index
> 06ad738..4cb5447 100644
> --- a/framework/pktgen_base.py
> +++ b/framework/pktgen_base.py
> @@ -170,7 +170,7 @@ class PacketGenerator(object):
>          bps_rx = []
>          pps_rx = []
>          self._prepare_transmission(stream_ids=stream_ids)
> -        self._start_transmission(stream_ids)
> +        self._start_transmission(stream_ids, options)
> 
>          delay = options.get('delay') or 5
>          time.sleep(delay)
> --
> 2.21.0

[dts] [PATCH V3 2/2] framework/pktgen: fix PacketGeneratorHelper missed rate

[yufengmx]

 setting

add missing stream rate option in prepare_stream_from_tginput method.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 framework/pktgen.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/framework/pktgen.py b/framework/pktgen.py
index 1c8acac..2c6cf7f 100644
--- a/framework/pktgen.py
+++ b/framework/pktgen.py
@@ -194,6 +194,7 @@ class PacketGeneratorHelper(object):
             pcap = config[2]
             _options = deepcopy(self.default_opt)
             _options['pcap'] = pcap
+            _options['stream_config']['rate'] = ratePercent
             # if vm is set
             if vm_config:
                 _options['fields_config'] = \
-- 
2.21.0

Re: [dts] [PATCH V3 2/2] framework/pktgen: fix PacketGeneratorHelper missed rate

[Tu, Lijuan]

Applied, thanks

> -----Original Message-----
> From: Mo, YufengX
> Sent: Friday, September 20, 2019 10:19 AM
> To: dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com>; Tu, Lijuan
> <lijuan.tu@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V3 2/2] framework/pktgen: fix PacketGeneratorHelper
> missed rate
> 
>  setting
> 
> add missing stream rate option in prepare_stream_from_tginput method.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  framework/pktgen.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/framework/pktgen.py b/framework/pktgen.py index
> 1c8acac..2c6cf7f 100644
> --- a/framework/pktgen.py
> +++ b/framework/pktgen.py
> @@ -194,6 +194,7 @@ class PacketGeneratorHelper(object):
>              pcap = config[2]
>              _options = deepcopy(self.default_opt)
>              _options['pcap'] = pcap
> +            _options['stream_config']['rate'] = ratePercent
>              # if vm is set
>              if vm_config:
>                  _options['fields_config'] = \
> --
> 2.21.0