From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44757A04A2; Tue, 5 Nov 2019 04:44:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1AB8D2C37; Tue, 5 Nov 2019 04:44:46 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0994B2BE9 for ; Tue, 5 Nov 2019 04:44:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2019 19:44:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,269,1569308400"; d="scan'208";a="232315251" Received: from ubuntu.sh.intel.com ([10.239.250.27]) by fmsmga002.fm.intel.com with ESMTP; 04 Nov 2019 19:44:42 -0800 From: Peng Zhihong To: dts@dpdk.org Cc: Peng Zhihong Date: Tue, 5 Nov 2019 11:30:42 +0800 Message-Id: <20191105033042.19599-1-zhihongx.peng@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dts] [PATCH V2] tests/TestSuite_userspace_ethtool.py:Before the exception exit, it needs to be re-bound to the DPDK. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" tests/TestSuite_userspace_ethtool.py:Before the exception exit, it needs to be re-bound to the DPDK. Signed-off-by: Peng Zhihong --- tests/TestSuite_userspace_ethtool.py | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py index 92724aa..31f8a87 100644 --- a/tests/TestSuite_userspace_ethtool.py +++ b/tests/TestSuite_userspace_ethtool.py @@ -247,12 +247,9 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator): sys_nic_info = self.linux_get_nic_info(intf_name) status, msg = self.check_driver_info(intf_name, sys_nic_info, dpdk_nic_infos[str(index)]) self.logger.info(msg) - self.verify(status, msg) - - for index in range(len(self.ports)): # bind to original driver - portinfo = portsinfo[index] portinfo['net_dev'].bind_driver(portinfo['ori_driver']) + self.verify(status, msg) self.dut.send_expect(self.cmd, "EthApp>", 60) # ethtool doesn't support port disconnect by tools of linux @@ -335,12 +332,9 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator): # get linux interface intf = netdev.get_interface_name() out = self.dut.send_expect("ethtool -d %s raw off file %s" % (intf, portinfo['reg_file']), "# ") - self.verify(("register" in out and "CTRL" in out), "Failed to dump %s registers" % intf) - - for index in range(len(self.ports)): # bind to original driver - portinfo = portsinfo[index] portinfo['net_dev'].bind_driver(portinfo['ori_driver']) + self.verify(("register" in out and "CTRL" in out), "Failed to dump %s registers" % intf) def test_retrieve_eeprom(self): """ -- 2.17.1