test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 0/1] tests/ipv4_reassembly: optimize packet send and capture
@ 2020-02-19  7:08 yufengmx
  2020-02-19  7:08 ` [dts] [PATCH V1 1/1] " yufengmx
  0 siblings, 1 reply; 3+ messages in thread
From: yufengmx @ 2020-02-19  7:08 UTC (permalink / raw)
  To: dts, lijuan.tu, lihongx.ma; +Cc: yufengmx

optimize packet send and capture for x722. 

yufengmx (1):
  optimize packet send and capture

 tests/TestSuite_ipv4_reassembly.py | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

-- 
2.21.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1 1/1] optimize packet send and capture
  2020-02-19  7:08 [dts] [PATCH V1 0/1] tests/ipv4_reassembly: optimize packet send and capture yufengmx
@ 2020-02-19  7:08 ` yufengmx
  2020-02-21  1:51   ` Tu, Lijuan
  0 siblings, 1 reply; 3+ messages in thread
From: yufengmx @ 2020-02-19  7:08 UTC (permalink / raw)
  To: dts, lijuan.tu, lihongx.ma; +Cc: yufengmx


optimize packet send and capture for x722.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_ipv4_reassembly.py | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_ipv4_reassembly.py b/tests/TestSuite_ipv4_reassembly.py
index 3f33809..8d69ac6 100644
--- a/tests/TestSuite_ipv4_reassembly.py
+++ b/tests/TestSuite_ipv4_reassembly.py
@@ -209,7 +209,7 @@ class TestIpReassembly(TestCase):
         self.tester.scapy_append(
             'pcap = rdpcap("%s")' % self.test_config.pcap_file)
         self.tester.scapy_append(
-            'sendp(pcap, iface="%s")' % self.test_config.tester_iface)
+            'sendp(pcap, iface="%s", verbose=False)' % self.test_config.tester_iface)
         self.tester.scapy_execute()
         time.sleep(5)
 
@@ -226,6 +226,12 @@ class TestIpReassembly(TestCase):
         os.remove(self.test_config.pcap_file)
         time.sleep(5)
 
+    @property
+    def wait_interval_for_tcpdump(self):
+        interval = 5 if self.nic in ["x722_37d2"] \
+                   else 0
+        return interval
+
     def tcpdump_start_sniffing(self):
         """
         Starts tcpdump in the background to sniff the tester interface where
@@ -238,12 +244,13 @@ class TestIpReassembly(TestCase):
                    self.test_config.tester_iface)
         self.tester.send_expect('rm -f tcpdump.pcap', '#')
         self.tester.send_expect(command, '#')
+        time.sleep(self.wait_interval_for_tcpdump)
 
     def tcpdump_stop_sniff(self):
         """
         Stops the tcpdump process running in the background.
         """
-
+        time.sleep(self.wait_interval_for_tcpdump)
         self.tester.send_expect('killall tcpdump', '#')
         # For the [pid]+ Done tcpdump... message after killing the process
         self.tester.send_expect('cat tcpdump.out', '#')
-- 
2.21.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1 1/1] optimize packet send and capture
  2020-02-19  7:08 ` [dts] [PATCH V1 1/1] " yufengmx
@ 2020-02-21  1:51   ` Tu, Lijuan
  0 siblings, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-02-21  1:51 UTC (permalink / raw)
  To: Mo, YufengX, dts, Ma,  LihongX

Applied,  thanks

> -----Original Message-----
> From: Mo, YufengX
> Sent: Wednesday, February 19, 2020 3:09 PM
> To: dts@dpdk.org; Tu, Lijuan <lijuan.tu@intel.com>; Ma, LihongX
> <lihongx.ma@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V1 1/1] optimize packet send and capture
> 
> 
> optimize packet send and capture for x722.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  tests/TestSuite_ipv4_reassembly.py | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_ipv4_reassembly.py
> b/tests/TestSuite_ipv4_reassembly.py
> index 3f33809..8d69ac6 100644
> --- a/tests/TestSuite_ipv4_reassembly.py
> +++ b/tests/TestSuite_ipv4_reassembly.py
> @@ -209,7 +209,7 @@ class TestIpReassembly(TestCase):
>          self.tester.scapy_append(
>              'pcap = rdpcap("%s")' % self.test_config.pcap_file)
>          self.tester.scapy_append(
> -            'sendp(pcap, iface="%s")' % self.test_config.tester_iface)
> +            'sendp(pcap, iface="%s", verbose=False)' %
> + self.test_config.tester_iface)
>          self.tester.scapy_execute()
>          time.sleep(5)
> 
> @@ -226,6 +226,12 @@ class TestIpReassembly(TestCase):
>          os.remove(self.test_config.pcap_file)
>          time.sleep(5)
> 
> +    @property
> +    def wait_interval_for_tcpdump(self):
> +        interval = 5 if self.nic in ["x722_37d2"] \
> +                   else 0
> +        return interval
> +
>      def tcpdump_start_sniffing(self):
>          """
>          Starts tcpdump in the background to sniff the tester interface where
> @@ -238,12 +244,13 @@ class TestIpReassembly(TestCase):
>                     self.test_config.tester_iface)
>          self.tester.send_expect('rm -f tcpdump.pcap', '#')
>          self.tester.send_expect(command, '#')
> +        time.sleep(self.wait_interval_for_tcpdump)
> 
>      def tcpdump_stop_sniff(self):
>          """
>          Stops the tcpdump process running in the background.
>          """
> -
> +        time.sleep(self.wait_interval_for_tcpdump)
>          self.tester.send_expect('killall tcpdump', '#')
>          # For the [pid]+ Done tcpdump... message after killing the process
>          self.tester.send_expect('cat tcpdump.out', '#')
> --
> 2.21.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-21  1:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19  7:08 [dts] [PATCH V1 0/1] tests/ipv4_reassembly: optimize packet send and capture yufengmx
2020-02-19  7:08 ` [dts] [PATCH V1 1/1] " yufengmx
2020-02-21  1:51   ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).