[dts] [PATCH V1] tests/port_control:change vm dpdk driver from igb

test suite reviews and discussions
 help / color / mirror / Atom feed

* [dts] [PATCH V1] tests/port_control:change vm dpdk driver from igb_uio to vfio-pci
@ 2020-06-29  7:30 Xie wei
  2020-06-29  7:55 ` Xie, WeiX
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Xie wei @ 2020-06-29  7:30 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

Change driver to vfio-pci on vm. Add param '--vfio-intr=legacy' to fix port link status still down issue, add some time to wait link status up.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_port_control.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py
index 1a588d3..147dc80 100644
--- a/tests/TestSuite_port_control.py
+++ b/tests/TestSuite_port_control.py
@@ -157,8 +157,8 @@ class TestPortControl(TestCase):
         terminal.send_expect("ifconfig %s hw ether %s" % (vf_if[1], self.vf_mac), "#")
         terminal.send_expect("ifconfig %s up" % vf_if[1], "#")
         terminal.send_expect("ip addr flush %s " % vf_if[1], "#")
-        terminal.send_expect("./usertools/dpdk-devbind.py -b igb_uio --force %s" % vf_pci[1], "#")
-        cmd = "./%s/app/testpmd -n 1 -w %s -- -i" % (self.target, vf_pci[1])
+        terminal.send_expect("./usertools/dpdk-devbind.py -b vfio-pci --force %s" % vf_pci[1], "#")
+        cmd = "./%s/app/testpmd -n 1 -w %s --vfio-intr=legacy -- -i" % (self.target, vf_pci[1])
         terminal.send_expect(cmd, "testpmd>", 10)
 
     def start_testpmd(self, terminal):
@@ -171,6 +171,7 @@ class TestPortControl(TestCase):
     def start_pmd_port(self, terminal):
         terminal.execute_cmd("port start all")
         terminal.execute_cmd("start")
+        time.sleep(5)
         terminal.wait_link_status_up('all', timeout=5)
         ret = terminal.get_port_link_status(self.port_id_0)
         self.verify(ret == "up", "port not up!")
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tests/port_control:change vm dpdk driver from igb_uio to vfio-pci
  2020-06-29  7:30 [dts] [PATCH V1] tests/port_control:change vm dpdk driver from igb_uio to vfio-pci Xie wei
@ 2020-06-29  7:55 ` Xie, WeiX
  2020-06-30 12:15   ` [dts] [PATCH] " lihong
  2020-06-30 12:19 ` lihong
  2020-07-01  6:05 ` [dts] " Tu, Lijuan
  2 siblings, 1 reply; 5+ messages in thread
From: Xie, WeiX @ 2020-06-29  7:55 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 1930 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


-----Original Message-----
From: Xie, WeiX 
Sent: Monday, June 29, 2020 3:31 PM
To: dts@dpdk.org
Cc: Xie, WeiX <weix.xie@intel.com>
Subject: [dts][PATCH V1] tests/port_control:change vm dpdk driver from igb_uio to vfio-pci

Change driver to vfio-pci on vm. Add param '--vfio-intr=legacy' to fix port link status still down issue, add some time to wait link status up.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_port_control.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py index 1a588d3..147dc80 100644
--- a/tests/TestSuite_port_control.py
+++ b/tests/TestSuite_port_control.py
@@ -157,8 +157,8 @@ class TestPortControl(TestCase):
         terminal.send_expect("ifconfig %s hw ether %s" % (vf_if[1], self.vf_mac), "#")
         terminal.send_expect("ifconfig %s up" % vf_if[1], "#")
         terminal.send_expect("ip addr flush %s " % vf_if[1], "#")
-        terminal.send_expect("./usertools/dpdk-devbind.py -b igb_uio --force %s" % vf_pci[1], "#")
-        cmd = "./%s/app/testpmd -n 1 -w %s -- -i" % (self.target, vf_pci[1])
+        terminal.send_expect("./usertools/dpdk-devbind.py -b vfio-pci --force %s" % vf_pci[1], "#")
+        cmd = "./%s/app/testpmd -n 1 -w %s --vfio-intr=legacy -- -i" % 
+ (self.target, vf_pci[1])
         terminal.send_expect(cmd, "testpmd>", 10)
 
     def start_testpmd(self, terminal):
@@ -171,6 +171,7 @@ class TestPortControl(TestCase):
     def start_pmd_port(self, terminal):
         terminal.execute_cmd("port start all")
         terminal.execute_cmd("start")
+        time.sleep(5)
         terminal.wait_link_status_up('all', timeout=5)
         ret = terminal.get_port_link_status(self.port_id_0)
         self.verify(ret == "up", "port not up!")
--
2.17.1


[-- Attachment #2: TestPortControl.log --]
[-- Type: application/octet-stream, Size: 67437 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH] [PATCH V1] tests/port_control:change vm dpdk driver from igb_uio to vfio-pci
  2020-06-29  7:55 ` Xie, WeiX
@ 2020-06-30 12:15   ` lihong
  0 siblings, 0 replies; 5+ messages in thread
From: lihong @ 2020-06-30 12:15 UTC (permalink / raw)
  To: lihongx.ma; +Cc: dts, Xie wei

tested-by:<lihongx.ma@intel.com>

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_port_control.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py
index 1a588d3..147dc80 100644
--- a/tests/TestSuite_port_control.py
+++ b/tests/TestSuite_port_control.py
@@ -157,8 +157,8 @@ class TestPortControl(TestCase):
         terminal.send_expect("ifconfig %s hw ether %s" % (vf_if[1], self.vf_mac), "#")
         terminal.send_expect("ifconfig %s up" % vf_if[1], "#")
         terminal.send_expect("ip addr flush %s " % vf_if[1], "#")
-        terminal.send_expect("./usertools/dpdk-devbind.py -b igb_uio --force %s" % vf_pci[1], "#")
-        cmd = "./%s/app/testpmd -n 1 -w %s -- -i" % (self.target, vf_pci[1])
+        terminal.send_expect("./usertools/dpdk-devbind.py -b vfio-pci --force %s" % vf_pci[1], "#")
+        cmd = "./%s/app/testpmd -n 1 -w %s --vfio-intr=legacy -- -i" % (self.target, vf_pci[1])
         terminal.send_expect(cmd, "testpmd>", 10)
 
     def start_testpmd(self, terminal):
@@ -171,6 +171,7 @@ class TestPortControl(TestCase):
     def start_pmd_port(self, terminal):
         terminal.execute_cmd("port start all")
         terminal.execute_cmd("start")
+        time.sleep(5)
         terminal.wait_link_status_up('all', timeout=5)
         ret = terminal.get_port_link_status(self.port_id_0)
         self.verify(ret == "up", "port not up!")
-- 
2.17.1
 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH] [PATCH V1] tests/port_control:change vm dpdk driver from igb_uio to vfio-pci
  2020-06-29  7:30 [dts] [PATCH V1] tests/port_control:change vm dpdk driver from igb_uio to vfio-pci Xie wei
  2020-06-29  7:55 ` Xie, WeiX
@ 2020-06-30 12:19 ` lihong
  2020-07-01  6:05 ` [dts] " Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: lihong @ 2020-06-30 12:19 UTC (permalink / raw)
  To: lihongx.ma; +Cc: dts, Xie wei

tested-by:<lihongx.ma@intel.com>

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_port_control.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py
index 1a588d3..147dc80 100644
--- a/tests/TestSuite_port_control.py
+++ b/tests/TestSuite_port_control.py
@@ -157,8 +157,8 @@ class TestPortControl(TestCase):
         terminal.send_expect("ifconfig %s hw ether %s" % (vf_if[1], self.vf_mac), "#")
         terminal.send_expect("ifconfig %s up" % vf_if[1], "#")
         terminal.send_expect("ip addr flush %s " % vf_if[1], "#")
-        terminal.send_expect("./usertools/dpdk-devbind.py -b igb_uio --force %s" % vf_pci[1], "#")
-        cmd = "./%s/app/testpmd -n 1 -w %s -- -i" % (self.target, vf_pci[1])
+        terminal.send_expect("./usertools/dpdk-devbind.py -b vfio-pci --force %s" % vf_pci[1], "#")
+        cmd = "./%s/app/testpmd -n 1 -w %s --vfio-intr=legacy -- -i" % (self.target, vf_pci[1])
         terminal.send_expect(cmd, "testpmd>", 10)
 
     def start_testpmd(self, terminal):
@@ -171,6 +171,7 @@ class TestPortControl(TestCase):
     def start_pmd_port(self, terminal):
         terminal.execute_cmd("port start all")
         terminal.execute_cmd("start")
+        time.sleep(5)
         terminal.wait_link_status_up('all', timeout=5)
         ret = terminal.get_port_link_status(self.port_id_0)
         self.verify(ret == "up", "port not up!")
-- 
2.17.1
 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tests/port_control:change vm dpdk driver from igb_uio to vfio-pci
  2020-06-29  7:30 [dts] [PATCH V1] tests/port_control:change vm dpdk driver from igb_uio to vfio-pci Xie wei
  2020-06-29  7:55 ` Xie, WeiX
  2020-06-30 12:19 ` lihong
@ 2020-07-01  6:05 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2020-07-01  6:05 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

Applied, thanks

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xie wei
> Sent: 2020年6月29日 15:31
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH V1] tests/port_control:change vm dpdk driver from
> igb_uio to vfio-pci
> 
> Change driver to vfio-pci on vm. Add param '--vfio-intr=legacy' to fix port link
> status still down issue, add some time to wait link status up.
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>
> ---
>  tests/TestSuite_port_control.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py
> index 1a588d3..147dc80 100644
> --- a/tests/TestSuite_port_control.py
> +++ b/tests/TestSuite_port_control.py
> @@ -157,8 +157,8 @@ class TestPortControl(TestCase):
>          terminal.send_expect("ifconfig %s hw ether %s" % (vf_if[1], self.vf_mac),
> "#")
>          terminal.send_expect("ifconfig %s up" % vf_if[1], "#")
>          terminal.send_expect("ip addr flush %s " % vf_if[1], "#")
> -        terminal.send_expect("./usertools/dpdk-devbind.py -b igb_uio --force %s" %
> vf_pci[1], "#")
> -        cmd = "./%s/app/testpmd -n 1 -w %s -- -i" % (self.target, vf_pci[1])
> +        terminal.send_expect("./usertools/dpdk-devbind.py -b vfio-pci --force %s" %
> vf_pci[1], "#")
> +        cmd = "./%s/app/testpmd -n 1 -w %s --vfio-intr=legacy -- -i" %
> + (self.target, vf_pci[1])
>          terminal.send_expect(cmd, "testpmd>", 10)
> 
>      def start_testpmd(self, terminal):
> @@ -171,6 +171,7 @@ class TestPortControl(TestCase):
>      def start_pmd_port(self, terminal):
>          terminal.execute_cmd("port start all")
>          terminal.execute_cmd("start")
> +        time.sleep(5)
>          terminal.wait_link_status_up('all', timeout=5)
>          ret = terminal.get_port_link_status(self.port_id_0)
>          self.verify(ret == "up", "port not up!")
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-07-01  6:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29  7:30 [dts] [PATCH V1] tests/port_control:change vm dpdk driver from igb_uio to vfio-pci Xie wei
2020-06-29  7:55 ` Xie, WeiX
2020-06-30 12:15   ` [dts] [PATCH] " lihong
2020-06-30 12:19 ` lihong
2020-07-01  6:05 ` [dts] " Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).