From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E2EEA0350; Tue, 30 Jun 2020 09:05:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 692E71BE0C; Tue, 30 Jun 2020 09:05:27 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 8F0E41B13C for ; Tue, 30 Jun 2020 09:05:25 +0200 (CEST) IronPort-SDR: qqnUjbFfnrp4MF8pbzH7K1ye3Ckrs6iiJi2SotW8NcN3bSpjj1dGsEuYqp6D22ywKHmBLlBo4L 7Wk+kEh18P+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="231017219" X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208";a="231017219" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2020 00:05:24 -0700 IronPort-SDR: FT/xUPUv1ZEsFdHZLMdAmxDtUviZ9rPIs34GKMJZkW14kWR2AMF4EVVrDV6OjKuMW6WSXXGBZ9 Xs4uEGk2jNzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208";a="295121615" Received: from unknown (HELO cb-dts.sh.intel.com) ([10.240.183.58]) by orsmga002.jf.intel.com with ESMTP; 30 Jun 2020 00:05:23 -0700 From: ChenBo To: dts@dpdk.org Cc: ChenBo Date: Tue, 30 Jun 2020 14:58:38 +0800 Message-Id: <20200630065838.18589-1-box.c.chen@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dts] [PATCH V1] test/dual_vlan: Code optimization X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Delete code that will not be executed Signed-off-by: ChenBo --- tests/TestSuite_dual_vlan.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py index daa23d3..73d3156 100644 --- a/tests/TestSuite_dual_vlan.py +++ b/tests/TestSuite_dual_vlan.py @@ -348,8 +348,6 @@ class TestDualVlan(TestCase): self.mode_config(extend="off") self.mode_config(strip="off") self.mode_config(stripq="off") - if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "fortpark_TLV", "fortpark_BASE-T","carlsville"]: - self.dut.send_expect('rx_vlan add %s %s' % (outvlan, dutRxPortId), "testpmd> ") self.vlan_send_packet(outvlan) out = self.get_tcpdump_package() self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error : " + out) @@ -366,8 +364,6 @@ class TestDualVlan(TestCase): self.vlan_send_packet(outvlan) out = self.get_tcpdump_package() self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error: " + out) - if self.nic in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "fortpark_TLV","fortpark_BASE-T" "carlsville"]: - self.dut.send_expect('rx_vlan rm %s %s' % (outvlan, dutRxPortId), "testpmd> ") def test_vlan_insert_config(self): """ -- 2.17.1