test suite reviews and discussions
 help / color / mirror / Atom feed
From: Xie wei <weix.xie@intel.com>
To: dts@dpdk.org
Cc: Xie wei <weix.xie@intel.com>
Subject: [dts] [PATCH V2] tests/cvl_advanced_iavf_rss:need quit testpmd to restore env
Date: Thu,  2 Jul 2020 10:53:31 +0800	[thread overview]
Message-ID: <20200702025331.27351-1-weix.xie@intel.com> (raw)

need quit testpmd before rmmoding ice.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_cvl_advanced_iavf_rss.py | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_cvl_advanced_iavf_rss.py b/tests/TestSuite_cvl_advanced_iavf_rss.py
index 1e6ac19..eaf55fa 100644
--- a/tests/TestSuite_cvl_advanced_iavf_rss.py
+++ b/tests/TestSuite_cvl_advanced_iavf_rss.py
@@ -1112,10 +1112,15 @@ class AdvancedIavfRSSTest(TestCase):
         self.create_testpmd_command(self.vf0_prop)
         error_rule = ["flow create 0 ingress pattern eth / ipv4 / udp / pfcp / end actions rss types pfcp end key_len 0 queues end / end ",
                       "flow create 0 ingress pattern eth / ipv6 / udp / pfcp / end actions rss types pfcp end key_len 0 queues end / end ", ]
-        for rule in error_rule:
-            out = self.pmd_output.execute_cmd(rule)
-            self.verify("Failed to create flow" in out, "Rule can be created")
-        self.replace_pkg(self.comms_pkg_name)
+        try:
+            for rule in error_rule:
+                out = self.pmd_output.execute_cmd(rule)
+                self.verify("Failed to create flow" in out, "Rule can be created")
+        except Exception as e:
+            raise Exception(e)
+        finally:
+            self.pmd_output.quit()
+            self.replace_pkg(self.comms_pkg_name)
 
     def replace_pkg(self, pkg):
         self.dut_session.send_expect("cd %s" % self.ddp_fdir, "# ")
-- 
2.17.1


             reply	other threads:[~2020-07-02  2:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02  2:53 Xie wei [this message]
2020-07-02  7:19 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702025331.27351-1-weix.xie@intel.com \
    --to=weix.xie@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).