test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V1] tests/kernelpf_iavf: remove extra code
  2020-08-11 15:11 [dts] [PATCH V1] tests/kernelpf_iavf: remove extra code Jianwei Mei
@ 2020-08-11  6:44 ` Xie, WeiX
  2020-08-13  5:39 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Xie, WeiX @ 2020-08-11  6:44 UTC (permalink / raw)
  To: Mei, JianweiX, dts; +Cc: Mei, JianweiX

[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianwei Mei
Sent: Tuesday, August 11, 2020 11:11 PM
To: dts@dpdk.org
Cc: Mei, JianweiX <jianweix.mei@intel.com>
Subject: [dts] [PATCH V1] tests/kernelpf_iavf: remove extra code

Same command in tear down, and if it is executed before the quit command, an error will occur, so delete them from test case.

Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 733d72f..f8fa94f 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -335,8 +335,6 @@ class TestKernelpfIavf(TestCase):
         out = self.vm_dut.get_session_output()
         self.verify(self.wrong_mac in out, 'vf receive pkt fail with wrong mac')
 
-        self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf, "# ")
-
     def test_vf_multicast(self):
         """
         enable kernel trust mode
@@ -363,7 +361,6 @@ class TestKernelpfIavf(TestCase):
         self.send_random_pkt(multicast_mac, count=1)
         out = self.vm_dut.get_session_output()
         self.verify(multicast_mac in out, 'vf receive pkt fail with multicast mac')
-        self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf, "# ")
 
     def test_vf_broadcast(self):
         """
--
2.17.1


[-- Attachment #2: TestKernelpfIavf.log --]
[-- Type: application/octet-stream, Size: 711312 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/kernelpf_iavf: remove extra code
@ 2020-08-11 15:11 Jianwei Mei
  2020-08-11  6:44 ` Xie, WeiX
  2020-08-13  5:39 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Jianwei Mei @ 2020-08-11 15:11 UTC (permalink / raw)
  To: dts; +Cc: Jianwei Mei

Same command in tear down, and if it is executed before the quit command, 
an error will occur, so delete them from test case.

Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 733d72f..f8fa94f 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -335,8 +335,6 @@ class TestKernelpfIavf(TestCase):
         out = self.vm_dut.get_session_output()
         self.verify(self.wrong_mac in out, 'vf receive pkt fail with wrong mac')
 
-        self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf, "# ")
-
     def test_vf_multicast(self):
         """
         enable kernel trust mode
@@ -363,7 +361,6 @@ class TestKernelpfIavf(TestCase):
         self.send_random_pkt(multicast_mac, count=1)
         out = self.vm_dut.get_session_output()
         self.verify(multicast_mac in out, 'vf receive pkt fail with multicast mac')
-        self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf, "# ")
 
     def test_vf_broadcast(self):
         """
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/kernelpf_iavf: remove extra code
  2020-08-11 15:11 [dts] [PATCH V1] tests/kernelpf_iavf: remove extra code Jianwei Mei
  2020-08-11  6:44 ` Xie, WeiX
@ 2020-08-13  5:39 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-08-13  5:39 UTC (permalink / raw)
  To: Mei, JianweiX, dts; +Cc: Mei, JianweiX

> Subject: [dts] [PATCH V1] tests/kernelpf_iavf: remove extra code
> 
> Same command in tear down, and if it is executed before the quit command, an
> error will occur, so delete them from test case.
> 
> Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
> ---
>  tests/TestSuite_kernelpf_iavf.py | 3 ---

Applied

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-13  5:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11 15:11 [dts] [PATCH V1] tests/kernelpf_iavf: remove extra code Jianwei Mei
2020-08-11  6:44 ` Xie, WeiX
2020-08-13  5:39 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).