test suite reviews and discussions
 help / color / mirror / Atom feed
From: Xiao Qimai <qimaix.xiao@intel.com>
To: dts@dpdk.org
Cc: Xiao Qimai <qimaix.xiao@intel.com>
Subject: [dts] [PATCH V1]framework/test_case: fix tear down fail will lost suite results
Date: Mon, 17 Aug 2020 01:51:29 +0000	[thread overview]
Message-ID: <20200817015129.69113-1-qimaix.xiao@intel.com> (raw)

*. this patch fix if got exception in tear down method of testsuite will lost result
scilently

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 framework/test_case.py | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/framework/test_case.py b/framework/test_case.py
index 110dafb..300b6ac 100644
--- a/framework/test_case.py
+++ b/framework/test_case.py
@@ -350,7 +350,7 @@ class TestCase(object):
                 'update_expected' in self.get_suite_cfg() and \
                 self.get_suite_cfg()['update_expected'] == True:
                 self._suite_conf.update_case_config(SUITE_SECTION_NAME)
-            self.tear_down()
+            self.execute_tear_down()
             return case_result
 
     def execute_test_cases(self):
@@ -440,6 +440,16 @@ class TestCase(object):
             # destroy all vfs
             dutobj.destroy_all_sriov_vfs()
 
+    def execute_tear_down(self):
+        """
+        execute suite tear_down function
+        """
+        try:
+            self.tear_down()
+        except Exception:
+            self.logger.error('tear_down failed:\n' + traceback.format_exc())
+            self.logger.warning("tear down %s failed, might iterfere next case's result!" % self.running_case)
+
     def enable_history(self, history):
         """
         Enable history for all CRB's default session
-- 
2.25.1


             reply	other threads:[~2020-08-17  2:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17  1:51 Xiao Qimai [this message]
2020-08-17  3:05 ` Xiao, QimaiX
2020-08-21  3:14 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200817015129.69113-1-qimaix.xiao@intel.com \
    --to=qimaix.xiao@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).